Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5 release] Refactored rpc docs #35808

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Conversation

rohan-varma
Copy link
Member

@rohan-varma rohan-varma commented Apr 1, 2020

This is a PR to merge #35109 into the 1.5 release. It refactors the RPC documentation as per requests from doc engineering. #35109 is landed into master.

Original Summary:
Reorganize as per jlin27 's comments. Screenshots added in comments.
Pull Request resolved: #35109

Differential Revision: D20788774

Pulled By: rohan-varma

fbshipit-source-id: 7d64be70ef76ed6ff303d05d39c338293c234766

Summary:
Reorganize as per jlin27 's comments. Screenshots added in comments.
Pull Request resolved: #35109

Differential Revision: D20788774

Pulled By: rohan-varma

fbshipit-source-id: 7d64be70ef76ed6ff303d05d39c338293c234766
@dr-ci
Copy link

dr-ci bot commented Apr 1, 2020

💊 CircleCI build failures summary and remediations

As of commit 7ff8982 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Test" (full log | pattern match details)

Apr 01 16:45:19 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.
Apr 01 16:45:19 processing existing schema:  aten::sparse_coo_tensor.size(int[] size, *, int dtype, int layout, Device device, bool pin_memory=False) -> (Tensor) 
Apr 01 16:45:19 processing existing schema:  aten::sparse_coo_tensor.indices(Tensor indices, Tensor values, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None) -> (Tensor) 
Apr 01 16:45:19 processing existing schema:  aten::sparse_coo_tensor.indices_size(Tensor indices, Tensor values, int[] size, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None) -> (Tensor) 
Apr 01 16:45:19 processing existing schema:  aten::split_with_sizes(Tensor self, int[] split_sizes, int dim=0) -> (Tensor[]) 
Apr 01 16:45:19 processing existing schema:  aten::squeeze(Tensor(a) self) -> (Tensor(a)) 
Apr 01 16:45:19 processing existing schema:  aten::squeeze.dim(Tensor(a) self, int dim) -> (Tensor(a)) 
Apr 01 16:45:19 processing existing schema:  aten::stft(Tensor self, int n_fft, int? hop_length=None, int? win_length=None, Tensor? window=None, bool normalized=False, bool onesided=True) -> (Tensor) 
Apr 01 16:45:19 skipping schema:  aten::sub_.Tensor(Tensor(a!) self, Tensor other, *, Scalar alpha=1) -> (Tensor(a!)) 
Apr 01 16:45:19 skipping schema:  aten::sub_.Scalar(Tensor(a!) self, Scalar other, Scalar alpha=1) -> (Tensor(a!)) 
Apr 01 16:45:19 processing existing schema:  aten::t(Tensor(a) self) -> (Tensor(a)) 
Apr 01 16:45:19 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Apr 01 16:45:19  
Apr 01 16:45:19 Broken ops: [ 
Apr 01 16:45:19 	aten::local_value(RRef(t) self) -> (t) 
Apr 01 16:45:19 	_aten::full(int[] size, Scalar fill_value, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None) -> (Tensor) 
Apr 01 16:45:19 	_aten::dequantize(Tensor self) -> (Tensor) 
Apr 01 16:45:19 	_aten::quantize_per_tensor(Tensor self, float scale, int zero_point, int dtype) -> (Tensor) 
Apr 01 16:45:19 	_aten::div.Tensor(Tensor self, Tensor other) -> (Tensor) 
Apr 01 16:45:19 	_aten::detach(Tensor self) -> (Tensor) 
Apr 01 16:45:19 	prim::id(AnyClassType? x) -> (int) 
Apr 01 16:45:19 	aten::owner(RRef(t) self) -> (__torch__.torch.classes.dist_rpc.WorkerInfo) 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need another PR to fix typo on master?

docs/source/rpc/index.rst Outdated Show resolved Hide resolved
facebook-github-bot pushed a commit that referenced this pull request Apr 2, 2020
Summary:
It's also fixed in the cherry pick PR #35808
Pull Request resolved: #35809

Differential Revision: D20803338

Pulled By: rohan-varma

fbshipit-source-id: 1925f367703faf053ab4b1c0ff0acb86230c5d89
@gchanan gchanan merged commit fb88942 into release/1.5 Apr 2, 2020
@facebook-github-bot facebook-github-bot deleted the cherry_pick_doc_change branch July 13, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants