Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_leaky_relu_inplace_with_neg_slope device-generic and skipIfRocm. #35816

Closed
wants to merge 1 commit into from

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Apr 1, 2020

Stack from ghstack:

Fixes #35689.

Differential Revision: D20796656

gchanan added a commit that referenced this pull request Apr 1, 2020
…Rocm.

Fixes #35689.

ghstack-source-id: 919571d23324687a4abdc0d9dbbd9d78bef9a3d8
Pull Request resolved: #35816
@dr-ci
Copy link

dr-ci bot commented Apr 1, 2020

💊 CircleCI build failures summary and remediations

As of commit 990df69 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

XLA failure

Job pytorch_xla_linux_xenial_py3_6_clang7_test is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 2 times.

@gchanan
Copy link
Contributor Author

gchanan commented Apr 1, 2020

XLA test failure doesn't look to be related.

@JackCaoG
Copy link
Collaborator

JackCaoG commented Apr 1, 2020

XLA test failure doesn't look to be related.

We had a small issue with disabled test list. It is fixed now, that test should be skipped.

@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in e0ee800.

gchanan added a commit that referenced this pull request Apr 2, 2020
…Rocm. (#35816)

Summary:
Pull Request resolved: #35816

Fixes #35689.

Test Plan: Imported from OSS

Differential Revision: D20796656

Pulled By: gchanan

fbshipit-source-id: 474790fe07899d9944644f6b3d7a15db1c2b96db
@facebook-github-bot facebook-github-bot deleted the gh/gchanan/231/head branch April 5, 2020 14:18
Rednickle pushed a commit to Rednickle/redttorch that referenced this pull request Apr 20, 2020
…Rocm. (#35816)

Summary:
Pull Request resolved: pytorch/pytorch#35816

Fixes pytorch/pytorch#35689.

Test Plan: Imported from OSS

Differential Revision: D20796656

Pulled By: gchanan

fbshipit-source-id: 474790fe07899d9944644f6b3d7a15db1c2b96db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants