Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make simple executor our default for OSS #36824

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

Krovatkin
Copy link
Contributor

Given that we keep running into the issue of incredibly long compilation times, we decided to switch to the simple executor which skips fusion-related passes and analyses. It might affect some users that rely on fusion on GPU to achieve their performance. profile. We will make a note in our release notes for such users to enable the profiling executor.

@Krovatkin Krovatkin requested review from suo and gchanan April 17, 2020 19:33
@Krovatkin Krovatkin requested a review from apaszke as a code owner April 17, 2020 19:33
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 17, 2020
@dr-ci
Copy link

dr-ci bot commented Apr 17, 2020

💊 Build failures summary and remediations

As of commit 4dc357f (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

XLA failure

Job pytorch_xla_linux_xenial_py3_6_clang7_build is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

@gchanan gchanan merged commit 9a51e47 into pytorch:release/1.5 Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants