Overwrite bazel if /usr/bin/bazel already exists. #36927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
approved these changes
Apr 20, 2020
malfet
reviewed
Apr 20, 2020
| @@ -259,7 +259,7 @@ if [[ "${BUILD_ENVIRONMENT}" == *xla* ]]; then | |||
| # XLA build requires Bazel | |||
| # We use bazelisk to avoid updating Bazel version manually. | |||
| sudo npm install -g @bazel/bazelisk | |||
| sudo ln -s "$(command -v bazelisk)" /usr/bin/bazel | |||
There was a problem hiding this comment.
Why not call get_bazel function from .jenkins/pytorch/common.sh?
There was a problem hiding this comment.
IMHO bazelisk is better than our get_bazel function, which installs a fixed version of bazel. bazelisk is able to read a bazelversion file in tensorflow and pull in the right version automatically.
It saves us from manually updating bazel version in pytorch CI.
There was a problem hiding this comment.
I think we should similarly add a .bazelversion file in pytorch and start using bazelisk in CI.
It has the benefit that:
- Easier to manage and update
- User would know which bazelversion to work with.
|
I'll merge this and we can work out a better solution later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.