New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fmt #37241
Closed
Closed
add fmt #37241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
Add this issue/PR to JIT oncall triage queue
label
Apr 24, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 24, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: fbf205224277848daaa8d3eacca27f9953d2d023 Pull Request resolved: #37241
💊 Build failures summary and remediationsAs of commit 3f5cc8a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 95 times. |
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: b1af8ce3fab8d5af217ce3e69d93c7f2a91b97ac Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 64fa5e6ef95059b2d26dde505930a0d147fc6255 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 780fa33b2ff22050fa1e5c4f10408a08abd07a57 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 24ce05ccb8246f219527ede936a35fbb0f5d87a7 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 26, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 5e76d84cb558c25ee39fc9a3457a0eec6857f93c Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 26, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: cbae4e082d4af37a3c0e34e69987dcbab41f57e6 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 26, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: a18837c9efc6ef854b9a29632840c225f243622a Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 27, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: caec011c80e1d3d35ef85cf050c9c0d9aa7158c2 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 27, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 6a2d58f2513b3b44592245819a04881c641603b7 Pull Request resolved: #37241
zdevito
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
fmt is a formatting library for C++. It has several properties that make it nice
for inclusion in PyTorch:
This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare).