Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable clang-tidy modernize-trailing-return #37888

Closed

Conversation

Krovatkin
Copy link
Contributor

too much noise from this warning
image

@Krovatkin Krovatkin requested a review from ezyang May 5, 2020 22:54
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented May 5, 2020

💊 Build failures summary and remediations

As of commit abe7fe9 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 10/10 broken upstream at merge base b57d82f on May 05 from 2:20pm to 4:36pm PDT (12 commits; 3706803 - a2fc7f7)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:


🚧 9 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

@facebook-github-bot
Copy link
Contributor

@Krovatkin merged this pull request in 92f750b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants