Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix histc with empty tensor error #38987

Closed
wants to merge 1 commit into from
Closed

Fix histc with empty tensor error #38987

wants to merge 1 commit into from

Conversation

ShawnZhong
Copy link
Contributor

@ShawnZhong ShawnZhong commented May 25, 2020 •
edited

Fix #38979

The error in mentioned #38979 is a cudaErrorInvalidConfiguration error:

This indicates that a kernel launch is requesting resources that can never be satisfied by the current device. Requesting more shared memory per block than the device supports will trigger this error, as will requesting too many threads or blocks. See cudaDeviceProp for more device limitations.

This is because we are trying to launch a kernel with block size 0.

@ShawnZhong ShawnZhong marked this pull request as ready for review May 25, 2020 17:14
@ShawnZhong ShawnZhong changed the title Fix histc empty tensor Fix histc with empty tensor error May 25, 2020
facebook-github-bot
facebook-github-bot reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ShawnZhong ShawnZhong deleted the histc_empty_tensor branch May 26, 2020 20:24
@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 12c219d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CUDA histc does not work for empty tensor.
5 participants
@ShawnZhong @facebook-github-bot @ezyang @pytorchbot @mruberry