Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #3556
I'm not sure this is the best way to implement because the
.contiguous()
calls might be slow.One alternative way to implement this is to copy and modify gather. Without any of the extra keyword modifiers, with
reduce=False
, the following is equivalent to NLLLossNd:I tried benchmarking this against what I have right now (this diff that uses
.contiguous()
calls and NLLLoss2d) and using gather is around 2x slower, even for non-contiguous inputs, so I went with this approach.Test Plan
Unit tests for NLLLossNd with a NLLLossNd reference function