Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong MSVC version constraint for CUDA 9.2 #40794

Conversation

peterjc123
Copy link
Collaborator

@peterjc123 peterjc123 commented Jun 30, 2020

Tested with #40782.

@dr-ci
Copy link

dr-ci bot commented Jun 30, 2020

💊 CI failures summary and remediations

As of commit 0752ebd (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_python_doc_push (1/1)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Jun 30 18:31:18 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:43:17: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr'
Jun 30 18:31:18 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:37:37: error: 'png_const_bytep' was not declared in this scope 
Jun 30 18:31:18    reader.ptr = png_const_bytep(datap) + 8; 
Jun 30 18:31:18                                      ^ 
Jun 30 18:31:18 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp: In lambda function: 
Jun 30 18:31:18 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:42:27: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:31:18          std::copy(reader->ptr, reader->ptr + bytes, output); 
Jun 30 18:31:18                            ^ 
Jun 30 18:31:18 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:42:40: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:31:18          std::copy(reader->ptr, reader->ptr + bytes, output); 
Jun 30 18:31:18                                         ^ 
Jun 30 18:31:18 /var/lib/jenkins/workspace/vision/torchvision/csrc/cpu/image/readpng_cpu.cpp:43:17: error: 'struct decodePNG(const at::Tensor&)::Reader' has no member named 'ptr' 
Jun 30 18:31:18          reader->ptr += bytes; 
Jun 30 18:31:18                  ^ 
Jun 30 18:31:18 error: command 'gcc' failed with exit status 1 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in 6e4f99b.

@peterjc123 peterjc123 deleted the fix_wrong_msvc_version_in_cuda_cmake branch July 1, 2020 03:35
peterjc123 added a commit to peterjc123/pytorch that referenced this pull request Jul 1, 2020
Summary:
Tested with pytorch#40782.
Pull Request resolved: pytorch#40794

Differential Revision: D22318045

Pulled By: malfet

fbshipit-source-id: a737ffd7cb8a6a9efb62b84378318f4c3800ad8f
malfet pushed a commit that referenced this pull request Jul 1, 2020
Summary:
Tested with #40782.
Pull Request resolved: #40794

Differential Revision: D22318045

Pulled By: malfet

fbshipit-source-id: a737ffd7cb8a6a9efb62b84378318f4c3800ad8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants