Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG: SciPy pip DLL load issue #40975

Closed

Conversation

tylerjereddy
Copy link
Contributor

@peterjc123 (this is related to your upstream report: scipy/scipy#12400)

  • do not merge--debug only! I tried to replicate
    pytorch CI in my fork but this is a bit easier
    if not too troublesome

  • this is an attempt to check for the fix for
    SciPy DLL load issue reported in pytorch CI
    in issue Errror loading scipy on CircleCI Windows jobs #40366 with our 1.5.0 release; at the moment,
    pytorch CI is using a conda install to avoid the DLL
    load issue observed with our PyPI wheel for Windows
    Python 3.6

  • the specific wheel in use in this feature branch
    contains a variety of attempted fixes--if they work,
    I will aim to backport them to a 1.5.1 release
    of SciPy

* do not merge--debug only! I tried to replicate
pytorch CI in my fork but this is a bit easier
if not too troublesome

* this is an attempt to check for the fix for
SciPy DLL load issue reported in pytorch CI
in issue pytorch#40366 with our `1.5.0` release; at the moment,
`pytorch` CI is using a conda install to avoid the DLL
load issue observed with our PyPI wheel for Windows
Python 3.6

* the specific wheel in use in this feature branch
contains a variety of attempted fixes--if they work,
I will aim to backport them to a `1.5.1` release
of SciPy
@peterjc123
Copy link
Collaborator

@tylerjereddy Thanks. Looking to the CI log, looks like you could not trigger a CI job here. I'll do the work for you.

@peterjc123 peterjc123 requested review from peterjc123 and removed request for peterjc123 July 4, 2020 03:09
@peterjc123
Copy link
Collaborator

@tylerjereddy It seems that the fix is working.

@tylerjereddy
Copy link
Contributor Author

great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants