Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find hip properly #42064

Closed
wants to merge 2 commits into from
Closed

Find hip properly #42064

wants to merge 2 commits into from

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Jul 25, 2020

Fixes #41886

@acxz acxz mentioned this pull request Jul 25, 2020
Closed
@dr-ci
Copy link

dr-ci bot commented Jul 25, 2020 •
edited

💊 CI failures summary and remediations

As of commit 638eda2 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 9 times.

@acxz
find hip properly
638eda2 
'HIP' and 'hip' represent two different targets. See: ROCm/rocFFT#304 (comment) As such we need to find 'hip' as well. This commits adds 'hip' and its deps 'AMDDeviceLibs' & 'amd_comgr' so that 'hip' dependent libraries like rocblas, rocfft, etc.(ROCm/rocFFT#303) can find 'hip' properly during the pytorch cmake configuration for ROCm
@t-vi
Copy link
Collaborator

t-vi commented Jul 26, 2020 •
edited

[Sorry about this, I hit an outdated CI page]

t-vi
t-vi approved these changes Jul 26, 2020
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @acxz .

@t-vi
Copy link
Collaborator

t-vi commented Jul 26, 2020

Looks good to me, let's give @jeffdaily a chance to look before I ask for merging.

facebook-github-bot
facebook-github-bot reviewed Jul 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jeffdaily
Copy link
Collaborator

LGTM

@t-vi
Copy link
Collaborator

t-vi commented Jul 27, 2020

@malfet thank you for importing. It seems that it triggered something with the FB-internal checks. If we can do anything to help it along, we'd be glad to.

@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in e59db43.

@acxz acxz deleted the find-hip branch July 27, 2020 22:23
@acxz acxz mentioned this pull request Sep 30, 2020
Closed
facebook-github-bot pushed a commit that referenced this pull request Oct 20, 2020
@acxz @facebook-github-bot
[Build] [CMake] [ROCm] find hsa-runtime64 properly (#45550)
5e0bfd7 
Summary:
Properly Fixes #44384
similar in vein to #42064

Pull Request resolved: #45550

Reviewed By: ezyang

Differential Revision: D24412674

Pulled By: malfet

fbshipit-source-id: f3d056c7069cb9d8a7d4174b604b9e3fbb14180b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

@t-vi t-vi t-vi approved these changes

Assignees
No one assigned
Labels
Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ROCm] [Build Error] [CMake] Cannot find hip
7 participants
@acxz @t-vi @jeffdaily @facebook-github-bot @malfet @pytorchbot @mruberry