[te] Fix casting of unsigned char, and abs(int) #44157

bertmaher · 2020-09-03T22:29:28Z

Stack from ghstack:

Fix frac in CUDA fuser #44152 Fix frac in CUDA fuser
Prevent the TE fuser from getting datatypes it can't handle #44160 Prevent the TE fuser from getting datatypes it can't handle
[te] Fix casting of unsigned char, and abs(int) #44157 [te] Fix casting of unsigned char, and abs(int)

Differential Revision: D23528507

[ghstack-poisoned]

ghstack-source-id: 9f939c4a78b832da338d851725a3b3b77c409b9e Pull Request resolved: #44157

dr-ci · 2020-09-03T22:39:19Z

💊 CI failures summary and remediations

As of commit 0dd0f65 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm3.7-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 26 times.

[ghstack-poisoned]

ZolotukhinM

Looks good! I guess you'll need to replace self.assertEqual(ref, t(x)) with np.testing.assert_allclose(...) to appease the CI gods though.

ZolotukhinM · 2020-09-04T00:45:35Z

test/test_jit_fuser_te.py

@@ -1152,20 +1152,48 @@ def rand(dtype, device="cuda"):
            torch.int16,
            torch.int32,
            torch.int64,
-            torch.float16,
-            torch.bfloat16,
+            # torch.float16,


Nit: maybe add a comment whether we want these to be supported at all?

Oh, yeah, float16 should be coming in soon-ish. The commented lines are a transient state for this stack :-)

ZolotukhinM · 2020-09-04T00:46:20Z

torch/csrc/jit/tensorexpr/cuda_codegen.cpp

@@ -186,7 +186,7 @@ void CudaPrinter::visit(const For* v) {
 }

 void CudaPrinter::visit(const Cast* v) {
-  os() << cudaDtypeCppString(v->dtype());
+  os() << "(" << cudaDtypeCppString(v->dtype()) << ")";


Ouch, how did it work? :)

I don't know when it became a thing but apparently you can cast by saying float(x), like it's a constructor. But that sorta doesn't parse if you do unsigned char(x). Clearly we need whitespace in identifiers! (I hope this reddit post is a joke: https://www.reddit.com/r/ProgrammerHumor/comments/4on81i/til_c_allows_u200b_zero_width_space_in_identifiers/ )

[ghstack-poisoned]

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

ngimel · 2020-09-07T23:17:36Z

torch/csrc/jit/tensorexpr/cuda_codegen.cpp

@@ -209,6 +209,9 @@ void CudaPrinter::visit(const Intrinsics* v) {
  if (returnType == ScalarType::Half || returnType == ScalarType::Float) {
    func_name = func_name + "f";
  }
+  if (v->op_type() == IntrinsicsOp::kFabs && is_integral(returnType)) {


does nvrtc not handle std::abs or ::abs? All this exp/expf is so last decade (and is not used in eager part of the codebase at all).

I think it does, actually. I don't know why we went the + "f" route, except that maybe the old fuser uses it? I'll take a note to use std:: in a follow-up.

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

codecov · 2020-09-08T07:24:55Z

Codecov Report

❗ No coverage uploaded for pull request base (gh/bertmaher/15/base@f6a7861). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             gh/bertmaher/15/base   #44157   +/-   ##
=======================================================
  Coverage                        ?   69.29%           
=======================================================
  Files                           ?      381           
  Lines                           ?    47652           
  Branches                        ?        0           
=======================================================
  Hits                            ?    33022           
  Misses                          ?    14630           
  Partials                        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a7861...0dd0f65. Read the comment docs.

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

facebook-github-bot · 2020-09-09T18:20:10Z

@bertmaher merged this pull request in 960c088.

[te] Fix casting of unsigned char, and abs(int)

8e2e2e2

[ghstack-poisoned]

bertmaher requested a review from apaszke as a code owner September 3, 2020 22:29

This was referenced Sep 3, 2020

[te] Disable reductions by default #44122

Closed

Fix frac in CUDA fuser #44152

Closed

bertmaher added a commit that referenced this pull request Sep 3, 2020

[te] Fix casting of unsigned char, and abs(int)

a109d40

ghstack-source-id: 9f939c4a78b832da338d851725a3b3b77c409b9e Pull Request resolved: #44157

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 3, 2020

bertmaher mentioned this pull request Sep 3, 2020

Prevent the TE fuser from getting datatypes it can't handle #44160

Closed

bertmaher requested review from zheng-xq, ZolotukhinM and nickgg September 3, 2020 23:32

Update on "[te] Fix casting of unsigned char, and abs(int)"

c2744f3

[ghstack-poisoned]

ZolotukhinM approved these changes Sep 4, 2020

View reviewed changes

bertmaher added 2 commits September 3, 2020 21:21

Update on "[te] Fix casting of unsigned char, and abs(int)"

59273cb

[ghstack-poisoned]

Update on "[te] Fix casting of unsigned char, and abs(int)"

0827798

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

ngimel reviewed Sep 7, 2020

View reviewed changes

Update on "[te] Fix casting of unsigned char, and abs(int)"

23bbc45

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

bertmaher added 2 commits September 8, 2020 10:11

Update on "[te] Fix casting of unsigned char, and abs(int)"

cf87af0

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

Update on "[te] Fix casting of unsigned char, and abs(int)"

0dd0f65

Differential Revision: [D23528507](https://our.internmc.facebook.com/intern/diff/D23528507) [ghstack-poisoned]

facebook-github-bot closed this in 960c088 Sep 9, 2020

facebook-github-bot added the merged label Sep 9, 2020

bertmaher mentioned this pull request Sep 10, 2020

Fix bug simplifying if-then-else when it can be removed #44462

Closed

facebook-github-bot deleted the gh/bertmaher/15/head branch September 13, 2020 14:16

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[te] Fix casting of unsigned char, and abs(int) #44157

[te] Fix casting of unsigned char, and abs(int) #44157

bertmaher commented Sep 3, 2020 •

edited

dr-ci bot commented Sep 3, 2020 •

edited

ZolotukhinM left a comment

ZolotukhinM Sep 4, 2020

bertmaher Sep 4, 2020

ZolotukhinM Sep 4, 2020

bertmaher Sep 4, 2020

ngimel Sep 7, 2020

bertmaher Sep 8, 2020

codecov bot commented Sep 8, 2020 •

edited

facebook-github-bot commented Sep 9, 2020

[te] Fix casting of unsigned char, and abs(int) #44157

[te] Fix casting of unsigned char, and abs(int) #44157

Conversation

bertmaher commented Sep 3, 2020 • edited

dr-ci bot commented Sep 3, 2020 • edited

💊 CI failures summary and remediations

ci.pytorch.org: 1 failed

ZolotukhinM left a comment

Choose a reason for hiding this comment

ZolotukhinM Sep 4, 2020

Choose a reason for hiding this comment

bertmaher Sep 4, 2020

Choose a reason for hiding this comment

ZolotukhinM Sep 4, 2020

Choose a reason for hiding this comment

bertmaher Sep 4, 2020

Choose a reason for hiding this comment

ngimel Sep 7, 2020

Choose a reason for hiding this comment

bertmaher Sep 8, 2020

Choose a reason for hiding this comment

codecov bot commented Sep 8, 2020 • edited

Codecov Report

facebook-github-bot commented Sep 9, 2020

bertmaher commented Sep 3, 2020 •

edited

dr-ci bot commented Sep 3, 2020 •

edited

codecov bot commented Sep 8, 2020 •

edited