Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA BFloat embedding #44848

Closed
wants to merge 13 commits into from
Closed

CUDA BFloat embedding #44848

wants to merge 13 commits into from

Conversation

zasdfgbnm
Copy link
Collaborator

No description provided.

@dr-ci
Copy link

dr-ci bot commented Sep 16, 2020

💊 CI failures summary and remediations

As of commit 62b1e8c (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 42 times.

@mruberry mruberry added module: cuda Related to torch.cuda, and CUDA support in general triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: bfloat16 labels Sep 17, 2020
@ngimel
Copy link
Collaborator

ngimel commented Sep 19, 2020

Can you please resolve conflict?

@zasdfgbnm
Copy link
Collaborator Author

@ngimel Done

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #44848 (8fd2184) into master (19f4c51) will decrease coverage by 12.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #44848       +/-   ##
===========================================
- Coverage   80.77%   68.19%   -12.58%     
===========================================
  Files        1867      410     -1457     
  Lines      201583    53232   -148351     
===========================================
- Hits       162819    36302   -126517     
+ Misses      38764    16930    -21834     
Impacted Files Coverage Δ
torch/testing/_internal/te_utils.py 0.00% <0.00%> (-82.15%) ⬇️
torch/nn/utils/memory_format.py 25.00% <0.00%> (-75.00%) ⬇️
torch/nn/modules/channelshuffle.py 0.00% <0.00%> (-63.64%) ⬇️
torch/backends/cudnn/rnn.py 0.00% <0.00%> (-54.55%) ⬇️
torch/multiprocessing/_atfork.py 61.53% <0.00%> (-30.77%) ⬇️
torch/cuda/random.py 22.97% <0.00%> (-28.38%) ⬇️
torch/backends/cudnn/__init__.py 59.74% <0.00%> (-27.28%) ⬇️
torch/cuda/__init__.py 55.17% <0.00%> (-23.38%) ⬇️
...enchmark/utils/valgrind_wrapper/timer_interface.py 25.78% <0.00%> (-22.45%) ⬇️
torch/__init__.py 65.25% <0.00%> (-18.22%) ⬇️
... and 1655 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cf1e1...7288f79. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Hi @zasdfgbnm!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@zasdfgbnm zasdfgbnm changed the title CUDA BFloat embedding, index_add, index_select, arange, sum, prod, sparse add CUDA BFloat embedding Dec 14, 2020
@zasdfgbnm
Copy link
Collaborator Author

@ngimel This is now working as well

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the bfloat-embedding-bag branch December 16, 2020 17:47
@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 86902f8.

facebook-github-bot pushed a commit that referenced this pull request Jan 6, 2021
Summary:
Dependency:
#48809 #48807 #48806 #48805 #48801 #44994 #44848

Pull Request resolved: #48810

Reviewed By: mruberry

Differential Revision: D25772955

Pulled By: ngimel

fbshipit-source-id: 353f130eb701f8b338a826d2edaea69e6e644ee9
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
Summary: Pull Request resolved: pytorch#44848

Reviewed By: izdeby

Differential Revision: D25574204

Pulled By: ngimel

fbshipit-source-id: b35f7253a6ad2b83f7b6b06862a5ab77295373e0
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
Summary:
Dependency:
pytorch#48809 pytorch#48807 pytorch#48806 pytorch#48805 pytorch#48801 pytorch#44994 pytorch#44848

Pull Request resolved: pytorch#48810

Reviewed By: mruberry

Differential Revision: D25772955

Pulled By: ngimel

fbshipit-source-id: 353f130eb701f8b338a826d2edaea69e6e644ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: bfloat16 module: cuda Related to torch.cuda, and CUDA support in general open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants