Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CUDA support for complex input for QR decomposition #45032

Closed
wants to merge 3 commits into from

Conversation

IvanYashchuk
Copy link
Collaborator

QR decomposition now works for complex inputs on GPU.

Ref. #33152

@IvanYashchuk IvanYashchuk added module: complex Related to complex number support in PyTorch module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul labels Sep 19, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 19, 2020

💊 CI failures summary and remediations

As of commit a180fef (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

1 failure confirmed as flaky and can be ignored:

  • pytorch_linux_bionic_py3_6_clang9_test

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #45032 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45032   +/-   ##
=======================================
  Coverage   67.83%   67.84%           
=======================================
  Files         384      384           
  Lines       49962    49962           
=======================================
+ Hits        33892    33896    +4     
+ Misses      16070    16066    -4     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️
torch/utils/_benchmark/utils/common.py 80.16% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0714c00...a180fef. Read the comment docs.

@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 22, 2020
Copy link
Contributor

@vishwakftw vishwakftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@IvanYashchuk
Copy link
Collaborator Author

@anjali411 can we merge this?

Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late response, I was running behind on the reviews. LGTM. my only comment would be that we should enable autograd for qr in an follow up PR

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@anjali411 merged this pull request in f010df3.

@IvanYashchuk IvanYashchuk deleted the qr-complex-cuda branch October 10, 2020 10:56
@rlucas7
Copy link
Contributor

rlucas7 commented Dec 13, 2020

sorry for the late response, I was running behind on the reviews. LGTM. my only comment would be that we should enable autograd for qr in an follow up PR

AFAICS the existing autograd for QR won't work for complex, it's missing a phase part on R matrix diagonals

@IvanYashchuk
Copy link
Collaborator Author

The derivative rule for QR was updated with #48489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: complex Related to complex number support in PyTorch module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants