New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CUDA support for complex input for QR decomposition #45032
Conversation
💊 CI failures summary and remediationsAs of commit a180fef (more details on the Dr. CI page):
1 failure confirmed as flaky and can be ignored:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
Codecov Report
@@ Coverage Diff @@
## master #45032 +/- ##
=======================================
Coverage 67.83% 67.84%
=======================================
Files 384 384
Lines 49962 49962
=======================================
+ Hits 33892 33896 +4
+ Misses 16070 16066 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@anjali411 can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late response, I was running behind on the reviews. LGTM. my only comment would be that we should enable autograd for qr in an follow up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@anjali411 merged this pull request in f010df3. |
AFAICS the existing autograd for QR won't work for complex, it's missing a phase part on |
The derivative rule for QR was updated with #48489. |
QR decomposition now works for complex inputs on GPU.
Ref. #33152