New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA BFloat16 signal windows #45155
Closed
Closed
CUDA BFloat16 signal windows #45155
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
83f52db
CUDA BFloat16 kaiser_window
zasdfgbnm 57b6602
Merge branch 'master' of github.com:pytorch/pytorch into bfloat-kaise…
zasdfgbnm c3b0af5
Merge branch 'master' of github.com:pytorch/pytorch into bfloat-kaise…
zasdfgbnm c83a102
Add test
zasdfgbnm 6f3ff43
do computation in T_ACC
zasdfgbnm 9aef8fb
update
zasdfgbnm 25ad846
save
zasdfgbnm 98c0c04
save
zasdfgbnm cdf7c49
fix
zasdfgbnm File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the intermediate computations of i0 args here should still be in accscalar_t? I can merge as though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is i0 bw bound or compute bound? If it is not bw bound, does it still make sense to compute on accscalar_t?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but it's doing internal computations in fp32 anyway, and here
is still doing repeated conversions and truncations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytorch/aten/src/ATen/native/Math.h
Line 542 in 719d29d
OK,
calc_i0
is already computing on float32 anyway