Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fx] GraphModule copy top level attributes from root #45182

Closed
wants to merge 6 commits into from
Closed

[fx] GraphModule copy top level attributes from root #45182

wants to merge 6 commits into from

Commits on Sep 23, 2020

  1. [fx] GraphModule copy top level attributes from root 

    Summary:
Previously only the attributes that's used in the graph is copied in the constructor
of GraphModule, this PR adds the support for copying all attributes by overriding `__dict__`

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3d6f304 View commit details
    Browse the repository at this point in the history

  2. Update on "[fx] GraphModule copy top level attributes from root" 

    Summary:
Previously only the attributes that's used in the graph is copied in the constructor
of GraphModule, this PR adds the support for copying all attributes by overriding `__dict__`

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    4f7c027 View commit details
    Browse the repository at this point in the history

  3. Update on "[fx] GraphModule copy top level attributes from root" 

    Summary:
Previously only the attributes that's used in the graph is copied in the constructor
of GraphModule, this PR adds the support for copying all attributes by overriding `__dict__`

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23858632](https://our.internmc.facebook.com/intern/diff/D23858632)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    7a3a17f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Update on "[fx] GraphModule copy top level attributes from root" 

    Summary:
Previously only the attributes that's used in the graph is copied in the constructor
of GraphModule, this PR adds the support for copying all attributes by overriding `__dict__`

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23858632](https://our.internmc.facebook.com/intern/diff/D23858632)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    db16998 View commit details
    Browse the repository at this point in the history

  2. Update on "[fx] GraphModule copy top level attributes from root" 

    Summary:
Previously only the attributes that's used in the graph is copied in the constructor
of GraphModule, this PR adds the support for copying all attributes by overriding `__dict__`

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23858632](https://our.internmc.facebook.com/intern/diff/D23858632)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    cc00e5f View commit details
    Browse the repository at this point in the history

  3. Update on "[fx] GraphModule copy top level attributes from root" 

    Summary:
Previously only the attributes that's used in the graph is copied in the constructor
of GraphModule, this PR adds the support for copying all attributes by overriding `__dict__`

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23858632](https://our.internmc.facebook.com/intern/diff/D23858632)

[ghstack-poisoned]
    @jerryzh168
    jerryzh168 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    cd94987 View commit details
    Browse the repository at this point in the history