Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Support nd mask index in opset >= 11 #45252

Closed
wants to merge 2 commits into from

Conversation

BowenBao
Copy link
Collaborator

Fixes below pattern for opset >= 11

return tensor[tensor > 0]

where rank of tensor > 1.

@BowenBao BowenBao added the module: onnx Related to torch.onnx label Sep 24, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 24, 2020

💊 CI failures summary and remediations

As of commit 7b0ebaa (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Oct 27 17:49:11 caused by: Connection refused (os error 111)
Oct 27 17:49:11 ++++ extract_trap_cmd 
Oct 27 17:49:11 ++++ printf '%s\n' '' 
Oct 27 17:49:11 +++ printf '%s\n' cleanup 
Oct 27 17:49:11 ++ trap -- ' 
Oct 27 17:49:11 cleanup' EXIT 
Oct 27 17:49:11 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *pytorch-win-* ]] 
Oct 27 17:49:11 ++ which sccache 
Oct 27 17:49:11 ++ sccache --stop-server 
Oct 27 17:49:11 Stopping sccache server... 
Oct 27 17:49:11 error: couldn't connect to server 
Oct 27 17:49:11 caused by: Connection refused (os error 111) 
Oct 27 17:49:11 ++ true 
Oct 27 17:49:11 ++ rm /var/lib/jenkins/sccache_error.log 
Oct 27 17:49:11 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Oct 27 17:49:11 ++ true 
Oct 27 17:49:11 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build == *rocm* ]] 
Oct 27 17:49:11 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Oct 27 17:49:11 ++ SCCACHE_IDLE_TIMEOUT=1200 
Oct 27 17:49:11 ++ RUST_LOG=sccache::server=error 
Oct 27 17:49:11 ++ sccache --start-server 
Oct 27 17:49:11 Starting sccache server... 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 24 times.

@dr-ci
Copy link

dr-ci bot commented Sep 24, 2020

💊 CI failures summary and remediations

As of commit 837538e0a6 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 6 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 25, 2020
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #45252 into master will decrease coverage by 0.57%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##           master   #45252      +/-   ##
==========================================
- Coverage   68.94%   68.37%   -0.58%     
==========================================
  Files         434      413      -21     
  Lines       56188    54592    -1596     
==========================================
- Hits        38740    37326    -1414     
+ Misses      17448    17266     -182     

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@BowenBao
Copy link
Collaborator Author

@bzinodev - hey any updates on this one? Is there test breakage blocking the merge? please let me know how i could help.

@BowenBao BowenBao force-pushed the onnx_mask_index branch 2 times, most recently from e5df294 to e62f382 Compare October 22, 2020 17:47
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 129b412.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants