Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quant] Use PlaceholderObserver as default dynamic quant observer #45343

Closed
wants to merge 16 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Sep 25, 2020

Stack from ghstack:

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D23933995

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@supriyar
Copy link
Contributor

You would have to probably update the tests as well.

@dr-ci
Copy link

dr-ci bot commented Sep 25, 2020

💊 CI failures summary and remediations

As of commit 6e9abe7 (more details on the Dr. CI page):


Commit 6e9abe7 was recently pushed. Waiting for builds...


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 75 times.

…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
…bserver"

Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9d5607f.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/442/head branch October 4, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants