New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quant] Use PlaceholderObserver as default dynamic quant observer #45343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Sep 25, 2020
supriyar
approved these changes
Sep 25, 2020
You would have to probably update the tests as well. |
💊 CI failures summary and remediationsAs of commit 6e9abe7 (more details on the Dr. CI page): Commit 6e9abe7 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 75 times. |
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
This was referenced Sep 29, 2020
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
…bserver" Summary: Current default dynamic quant observer is not correct since we don't accumulate min/max and we don't need to calculate qparams. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23933995](https://our.internmc.facebook.com/intern/diff/D23933995) [ghstack-poisoned]
This pull request has been merged in 9d5607f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Current default dynamic quant observer is not correct since we don't accumulate
min/max and we don't need to calculate qparams.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23933995