Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to PG backend and make TP backend stable. #45356

Conversation

pritamdamania87
Copy link
Contributor

@pritamdamania87 pritamdamania87 commented Sep 25, 2020

Stack from ghstack:

In this PR, I'm adding a warning to the PG backend mentioning it would
be deprecated in the future. In addition to this I removed the warning from the
TP backend that it is a beta feature.

Differential Revision: D23940144

In this PR, I'm adding a warning to the PG backend mentioning it would
be deprecated in the future. In addition to this I removed the warning from the
TP backend that it is a beta feature.

Differential Revision: [D23940144](https://our.internmc.facebook.com/intern/diff/D23940144/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Sep 25, 2020
In this PR, I'm adding a warning to the PG backend mentioning it would
be deprecated in the future. In addition to this I removed the warning from the
TP backend that it is a beta feature.

Differential Revision: [D23940144](https://our.internmc.facebook.com/intern/diff/D23940144/)

ghstack-source-id: 112940501
Pull Request resolved: #45356
@dr-ci
Copy link

dr-ci bot commented Sep 25, 2020

💊 CI failures summary and remediations

As of commit 7075e91 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 25 23:53:40 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future
Sep 25 23:53:40 At: 
Sep 25 23:53:40   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 25 23:53:40   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 25 23:53:40  
Sep 25 23:53:40 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 25 23:53:40  
Sep 25 23:53:40 At: 
Sep 25 23:53:40   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 25 23:53:40   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 25 23:53:40  
Sep 25 23:53:40 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 25 23:53:40  
Sep 25 23:53:40 At: 
Sep 25 23:53:40   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 25 23:53:40   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 25 23:53:40  
Sep 25 23:53:40 ok (1.226s) 
Sep 25 23:53:41   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 25 23:53:41 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 25 23:53:41 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 25 23:53:41 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 

See CircleCI build pytorch_linux_backward_compatibility_check_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Sep 25 21:13:32 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.
Sep 25 21:13:32 processing existing schema:  __setstate__(__torch__.torch.classes.quantized.EmbeddingPackedParamsBase _0, (int, Tensor[], float[], int[]) _1) -> (None _0) 
Sep 25 21:13:32 processing existing schema:  bit_rate(__torch__.torch.classes.quantized.EmbeddingPackedParamsBase _0) -> (int _0) 
Sep 25 21:13:32 processing existing schema:  version(__torch__.torch.classes.quantized.EmbeddingPackedParamsBase _0) -> (int _0) 
Sep 25 21:13:32 processing existing schema:  __getstate__(__torch__.torch.classes.xnnpack.LinearOpContext _0) -> ((Tensor, Tensor?, Scalar?, Scalar?) _0) 
Sep 25 21:13:32 processing existing schema:  __setstate__(__torch__.torch.classes.xnnpack.LinearOpContext _0, (Tensor, Tensor?, Scalar?, Scalar?) _1) -> (None _0) 
Sep 25 21:13:32 processing existing schema:  __getstate__(__torch__.torch.classes.xnnpack.Conv2dOpContext _0) -> ((Tensor, Tensor?, int[], int[], int[], int, Scalar?, Scalar?) _0) 
Sep 25 21:13:32 processing existing schema:  __setstate__(__torch__.torch.classes.xnnpack.Conv2dOpContext _0, (Tensor, Tensor?, int[], int[], int[], int, Scalar?, Scalar?) _1) -> (None _0) 
Sep 25 21:13:32 processing existing schema:  __getstate__(__torch__.torch.classes.xnnpack.TransposeConv2dOpContext _0) -> ((Tensor, Tensor?, int[], int[], int[], int[], int, Scalar?, Scalar?) _0) 
Sep 25 21:13:32 processing existing schema:  __setstate__(__torch__.torch.classes.xnnpack.TransposeConv2dOpContext _0, (Tensor, Tensor?, int[], int[], int[], int[], int, Scalar?, Scalar?) _1) -> (None _0) 
Sep 25 21:13:32 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Sep 25 21:13:32 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Sep 25 21:13:32  
Sep 25 21:13:32 Broken ops: [ 
Sep 25 21:13:32 	static::mul.a(Tensor a, Tensor b) -> (Tensor) 
Sep 25 21:13:32 	static::mul.b(Tensor a, int b) -> (Tensor) 
Sep 25 21:13:32 	static::add(Tensor a, Tensor b) -> (Tensor) 
Sep 25 21:13:32 ] 
Sep 25 21:13:32 + cleanup 
Sep 25 21:13:32 + retcode=1 
Sep 25 21:13:32 + set +x 
Sep 25 21:13:32 =================== sccache compilation log =================== 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3b7e4f8.

@facebook-github-bot facebook-github-bot deleted the gh/pritamdamania87/165/head branch September 29, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants