Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] Distance-agnostic triplet margin loss #45377

Closed
wants to merge 7 commits into from
Closed

[c++] Distance-agnostic triplet margin loss #45377

wants to merge 7 commits into from

Commits on Sep 26, 2020

  1. [c++] Distance-agnostic triplet margin loss 

    [ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    08fab1c View commit details
    Browse the repository at this point in the history

  2. Update on "[c++] Distance-agnostic triplet margin loss" 

    This PR adds a C++ implementation of the TripletMarginWithDistanceLoss, for which the Python implementation was introduced in PR #43680.  It's based on PR #44072, but I'm resubmitting this to unlink it from Phabricator.

cc: @mruberry @albanD @glaringlee 

[ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    25036b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Update on "[c++] Distance-agnostic triplet margin loss" 

    This PR adds a C++ implementation of the TripletMarginWithDistanceLoss, for which the Python implementation was introduced in PR #43680.  It's based on PR #44072, but I'm resubmitting this to unlink it from Phabricator.

cc: @mruberry @albanD @glaringlee 

[ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    178a20e View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Update on "[c++] Distance-agnostic triplet margin loss" 

    This PR adds a C++ implementation of the TripletMarginWithDistanceLoss, for which the Python implementation was introduced in PR #43680.  It's based on PR #44072, but I'm resubmitting this to unlink it from Phabricator.

cc: @mruberry @albanD @glaringlee 

[ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    642d2dd View commit details
    Browse the repository at this point in the history

  2. Update on "[c++] Distance-agnostic triplet margin loss" 

    This PR adds a C++ implementation of the TripletMarginWithDistanceLoss, for which the Python implementation was introduced in PR #43680.  It's based on PR #44072, but I'm resubmitting this to unlink it from Phabricator.

cc: @mruberry @albanD @glaringlee 

[ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    168db3c View commit details
    Browse the repository at this point in the history

  3. Update on "[c++] Distance-agnostic triplet margin loss" 

    This PR adds a C++ implementation of the TripletMarginWithDistanceLoss, for which the Python implementation was introduced in PR #43680.  It's based on PR #44072, but I'm resubmitting this to unlink it from Phabricator.

cc: @mruberry @albanD @glaringlee 

[ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    2b5c4ef View commit details
    Browse the repository at this point in the history

  4. Update on "[c++] Distance-agnostic triplet margin loss" 

    This PR adds a C++ implementation of the TripletMarginWithDistanceLoss, for which the Python implementation was introduced in PR #43680.  It's based on PR #44072, but I'm resubmitting this to unlink it from Phabricator.

cc: @mruberry @albanD @glaringlee 

[ghstack-poisoned]
    @ethch18
    ethch18 committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    023aa43 View commit details
    Browse the repository at this point in the history