Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Make spelling of 'nonnegative' consistent in TripletMarginWithDistanceLoss #45378

Closed
wants to merge 1 commit into from

Conversation

ethch18
Copy link

@ethch18 ethch18 commented Sep 26, 2020

Stack from ghstack:

This PR fixes some inconsistencies in the docs of nn.TripletMarginWithDistanceLoss, specifically w.r.t. the spelling of the word "nonnegative" (vs. "non-negative"). It seems that "nonnegative" is more common in general, but I'm not sure if there's a preference; I've changed all instances to that for now but am happy to go the other way.

nonnegative

ethch18 added a commit that referenced this pull request Sep 26, 2020
…stanceLoss

ghstack-source-id: 05a613598f17fc7b414bb319c20f2d5673894f05
Pull Request resolved: #45378
@ethch18 ethch18 changed the title [nn] Make spelling of 'nonnegative' consistent in TripletMarginWithDistanceLoss [docs] Make spelling of 'nonnegative' consistent in TripletMarginWithDistanceLoss Sep 26, 2020
@ethch18 ethch18 linked an issue Sep 26, 2020 that may be closed by this pull request
@ethch18 ethch18 requested review from mruberry and albanD and removed request for apaszke September 26, 2020 18:10
@dr-ci
Copy link

dr-ci bot commented Sep 26, 2020

💊 CI failures summary and remediations

As of commit aedee49 (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_doc_test (1/3)

Step: "Doc test" (full log | diagnosis details | 🔁 rerun)

Sep 26 18:43:35 caused by: Connection refused (os error 111)
Sep 26 18:43:34 +++++ extract_trap_cmd 
Sep 26 18:43:34 +++++ printf '%s\n' '' 
Sep 26 18:43:34 ++++ printf '%s\n' cleanup 
Sep 26 18:43:34 +++ trap -- ' 
Sep 26 18:43:34 cleanup' EXIT 
Sep 26 18:43:34 +++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *pytorch-win-* ]] 
Sep 26 18:43:34 +++ which sccache 
Sep 26 18:43:34 +++ sccache --stop-server 
Sep 26 18:43:35 Stopping sccache server... 
Sep 26 18:43:35 error: couldn't connect to server 
Sep 26 18:43:35 caused by: Connection refused (os error 111) 
Sep 26 18:43:35 +++ true 
Sep 26 18:43:35 +++ rm /var/lib/jenkins/sccache_error.log 
Sep 26 18:43:35 +++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build == *rocm* ]] 
Sep 26 18:43:35 +++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Sep 26 18:43:35 +++ SCCACHE_IDLE_TIMEOUT=1200 
Sep 26 18:43:35 +++ RUST_LOG=sccache::server=error 
Sep 26 18:43:35 +++ sccache --start-server 
Sep 26 18:43:35 Starting sccache server... 
Sep 26 18:43:35 +++ sccache --zero-stats 
Sep 26 18:43:35 Compile requests                 0 

See CircleCI build pytorch_python_doc_build (2/3)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Sep 26 18:54:53 Makefile:38: recipe for target 'html' failed
Sep 26 18:54:52 copying images... [100%] scripts/activation_images/ReLU6.png 
Sep 26 18:54:52  
Sep 26 18:54:52 copying static files... ... done 
Sep 26 18:54:52 copying extra files... done 
Sep 26 18:54:53 dumping search index in English (code: en)... done 
Sep 26 18:54:53 dumping object inventory... done 
Sep 26 18:54:53 build finished with problems, 4 warnings. 
Sep 26 18:54:53 /var/lib/jenkins/workspace/docs/src/pytorch-sphinx-theme/pytorch_sphinx_theme/search.html:21: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead. 
Sep 26 18:54:53   {% trans %}Please activate JavaScript to enable the search 
Sep 26 18:54:53 make: *** [html] Error 1 
Sep 26 18:54:53 Makefile:38: recipe for target 'html' failed 

See CircleCI build pytorch_macos_10_13_py3_test (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Sep 26 19:57:48 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future
Sep 26 19:57:48 At: 
Sep 26 19:57:48   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 26 19:57:48   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 26 19:57:48  
Sep 26 19:57:48 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 26 19:57:48  
Sep 26 19:57:48 At: 
Sep 26 19:57:48   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 26 19:57:48   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 26 19:57:48  
Sep 26 19:57:48 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Sep 26 19:57:48  
Sep 26 19:57:48 At: 
Sep 26 19:57:48   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(94): serialize 
Sep 26 19:57:48   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(146): serialize 
Sep 26 19:57:48  
Sep 26 19:57:48 ok (1.510s) 
Sep 26 19:57:49   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 26 19:57:49 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 26 19:57:49 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Sep 26 19:57:49 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@mruberry
Copy link
Collaborator

Seems fine. If you like you can include this fix with another more substantial PR. I'd prefer we didn't spin up a bunch of internal builds just for this.

@ethch18
Copy link
Author

ethch18 commented Sep 27, 2020

Sure, does it have to be a Python PR? I have PR #45377 open but it's a C++ one, not sure if that will clutter things more.

@mruberry
Copy link
Collaborator

Sure, does it have to be a Python PR? I have PR #45377 open but it's a C++ one, not sure if that will clutter things more.

Adding it to #45377 sounds good.

@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 28, 2020
@ethch18
Copy link
Author

ethch18 commented Sep 29, 2020

Closing this since I've incorporated it into #45377

@ethch18 ethch18 closed this Sep 29, 2020
@facebook-github-bot facebook-github-bot deleted the gh/ethch18/6/head branch October 30, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Generic Triplet-Margin Loss
4 participants