New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Make spelling of 'nonnegative' consistent in TripletMarginWithDistanceLoss #45378
Conversation
…stanceLoss [ghstack-poisoned]
…stanceLoss ghstack-source-id: 05a613598f17fc7b414bb319c20f2d5673894f05 Pull Request resolved: #45378
💊 CI failures summary and remediationsAs of commit aedee49 (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages: pytorch_doc_test (1/3)Step: "Doc test" (full log | diagnosis details | 🔁 rerun)
|
Seems fine. If you like you can include this fix with another more substantial PR. I'd prefer we didn't spin up a bunch of internal builds just for this. |
Sure, does it have to be a Python PR? I have PR #45377 open but it's a C++ one, not sure if that will clutter things more. |
Closing this since I've incorporated it into #45377 |
Stack from ghstack:
This PR fixes some inconsistencies in the docs of
nn.TripletMarginWithDistanceLoss
, specifically w.r.t. the spelling of the word "nonnegative" (vs. "non-negative"). It seems that "nonnegative" is more common in general, but I'm not sure if there's a preference; I've changed all instances to that for now but am happy to go the other way.