example of splitting up an FX graph into smaller subgraphs with own submodules #45404

Lilyjjo · 2020-09-28T00:21:07Z

Stack from ghstack:

example of splitting up an FX graph into smaller subgraphs with own submodules #45404 example of splitting up an FX graph into smaller subgraphs with own submodules

Differential Revision: D23956147

…ubmodules [ghstack-poisoned]

…ubmodules ghstack-source-id: c0fd45f73b59740dded48bd355bcd622f1ab8c55 Pull Request resolved: #45404

dr-ci · 2020-09-28T01:07:43Z

💊 CI failures summary and remediations

As of commit 08565d4 (more details on the Dr. CI page):

Commit 08565d4 was recently pushed. Waiting for builds...

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 43 times.

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

…ubmodules ghstack-source-id: 1bda5dfcfc897f7de45ee0a1fd53fe1c1de7544c Pull Request resolved: #45404 has mypy errors as follows: torch/fx/experimental/subgraph_creation_example.py:139: error: Argument "args" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:140: error: Argument "kwargs" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Dict[str, Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:177: error: Argument 2 to "call_module" of "Graph" has incompatible type "List[Node]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:182: error: Value of type "Proxy" is not indexable [index] Found 4 errors in 1 file (checked 1 source file) I'm not sure how to fix these

torch/fx/experimental/subgraph_creation_example.py

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

…ubmodules ghstack-source-id: 98bbfea76824b765785c08d13eff905e732b5fc6 Pull Request resolved: #45404 has mypy errors as follows: torch/fx/experimental/subgraph_creation_example.py:139: error: Argument "args" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:140: error: Argument "kwargs" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Dict[str, Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:177: error: Argument 2 to "call_module" of "Graph" has incompatible type "List[Node]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:182: error: Value of type "Proxy" is not indexable [index] Found 4 errors in 1 file (checked 1 source file) I'm not sure how to fix these

Lilyjjo · 2020-09-29T16:26:40Z

torch/fx/experimental/subgraph_creation_example.py

+                partition.targets[node.target] = target_attr
+                target = target_atoms[-1]
+
+            new_node = partition.graph.create_node(op=node.op, target=target, args=gathered_args,  # type: ignore 


There are two mypy errors here that I'm not sure how to go about resolving, both are related to the types of the args/kwargs

mypy error: Argument "args" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type]

error: Argument "kwargs" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Dict[str, Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]]]" [arg-type]

I can't repro this locally but I think if you put:

assert isinstance(gathered_args, tuple) assert isinstance(gathered_kwargs, dict)

Before this line, mypy might match the types correctly

yep this fixed it-- thanks

torch/fx/experimental/subgraph_creation_example.py

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

…ubmodules ghstack-source-id: 3bdd63f180a0b8d0434bbef955ad662ed77ddbc5 Pull Request resolved: #45404 has mypy errors as follows: torch/fx/experimental/subgraph_creation_example.py:139: error: Argument "args" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:140: error: Argument "kwargs" to "create_node" of "Graph" has incompatible type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]"; expected "Optional[Dict[str, Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:177: error: Argument 2 to "call_module" of "Graph" has incompatible type "List[Node]"; expected "Optional[Tuple[Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None], ...]]" [arg-type] torch/fx/experimental/subgraph_creation_example.py:182: error: Value of type "Proxy" is not indexable [index] Found 4 errors in 1 file (checked 1 source file) I'm not sure how to fix these

codecov · 2020-09-29T23:14:32Z

Codecov Report

❗ No coverage uploaded for pull request base (gh/Lilyjjo/8/base@4f685ec). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             gh/Lilyjjo/8/base   #45404   +/-   ##
====================================================
  Coverage                     ?   68.55%           
====================================================
  Files                        ?      409           
  Lines                        ?    52592           
  Branches                     ?        0           
====================================================
  Hits                         ?    36056           
  Misses                       ?    16536           
  Partials                     ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f685ec...08565d4. Read the comment docs.

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

…ubmodules ghstack-source-id: e53954180a6c8358168c46c45be6db097a7fb20f Pull Request resolved: #45404 moved from torch/fx/experimental to test/test_fx.py

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

…ubmodules ghstack-source-id: 19c439eb0a11f968361cc4d2f5b6f6ba471ed47f Pull Request resolved: #45404 moved from torch/fx/experimental to test/test_fx.py

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

…ubmodules ghstack-source-id: 0d5bae18ae5b8f6b7f4ab064aef3ec03dfa3059f Pull Request resolved: #45404 moved from torch/fx/experimental to test/test_fx.py

facebook-github-bot · 2020-10-02T04:11:57Z

@Lilyjjo merged this pull request in f6dc256.

example of splitting up an FX graph into smaller subgraphs with own s…

69d8223

…ubmodules [ghstack-poisoned]

Lilyjjo added a commit that referenced this pull request Sep 28, 2020

example of splitting up an FX graph into smaller subgraphs with own s…

7bd11ee

…ubmodules ghstack-source-id: c0fd45f73b59740dded48bd355bcd622f1ab8c55 Pull Request resolved: #45404

facebook-github-bot added the fx label Sep 28, 2020

Lilyjjo linked an issue Sep 28, 2020 that may be closed by this pull request

[FX] Write up an example of splitting up an FX graph into smaller subgraphs #43813

Closed

Update on "example of splitting up an FX graph into smaller subgraphs…

e648a9e

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Lilyjjo commented Sep 28, 2020

View reviewed changes

torch/fx/experimental/subgraph_creation_example.py Show resolved Hide resolved

Lilyjjo commented Sep 28, 2020

View reviewed changes

torch/fx/experimental/subgraph_creation_example.py Outdated Show resolved Hide resolved

Lilyjjo commented Sep 28, 2020

View reviewed changes

torch/fx/experimental/subgraph_creation_example.py Outdated Show resolved Hide resolved

Lilyjjo requested a review from jamesr66a September 28, 2020 17:26

Update on "example of splitting up an FX graph into smaller subgraphs…

0ee6910

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Lilyjjo commented Sep 29, 2020

View reviewed changes

Update on "example of splitting up an FX graph into smaller subgraphs…

83179e0

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Update on "example of splitting up an FX graph into smaller subgraphs…

d0c9415

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Update on "example of splitting up an FX graph into smaller subgraphs…

951b73b

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Update on "example of splitting up an FX graph into smaller subgraphs…

daad6ae

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

jamesr66a approved these changes Sep 30, 2020

View reviewed changes

Update on "example of splitting up an FX graph into smaller subgraphs…

3b37e97

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Update on "example of splitting up an FX graph into smaller subgraphs…

93e654c

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Update on "example of splitting up an FX graph into smaller subgraphs…

23f67df

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

Update on "example of splitting up an FX graph into smaller subgraphs…

08565d4

… with own submodules" Differential Revision: [D23956147](https://our.internmc.facebook.com/intern/diff/D23956147) [ghstack-poisoned]

facebook-github-bot closed this in f6dc256 Oct 2, 2020

facebook-github-bot added the merged label Oct 2, 2020

facebook-github-bot deleted the gh/Lilyjjo/8/head branch October 5, 2020 14:18

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

example of splitting up an FX graph into smaller subgraphs with own submodules #45404

example of splitting up an FX graph into smaller subgraphs with own submodules #45404

Lilyjjo commented Sep 28, 2020 •

edited

dr-ci bot commented Sep 28, 2020 •

edited

Lilyjjo Sep 29, 2020

jamesr66a Sep 29, 2020

Lilyjjo Sep 29, 2020

codecov bot commented Sep 29, 2020 •

edited

facebook-github-bot commented Oct 2, 2020

example of splitting up an FX graph into smaller subgraphs with own submodules #45404

example of splitting up an FX graph into smaller subgraphs with own submodules #45404

Conversation

Lilyjjo commented Sep 28, 2020 • edited

dr-ci bot commented Sep 28, 2020 • edited

💊 CI failures summary and remediations

Lilyjjo Sep 29, 2020

Choose a reason for hiding this comment

jamesr66a Sep 29, 2020

Choose a reason for hiding this comment

Lilyjjo Sep 29, 2020

Choose a reason for hiding this comment

codecov bot commented Sep 29, 2020 • edited

Codecov Report

facebook-github-bot commented Oct 2, 2020

Lilyjjo commented Sep 28, 2020 •

edited

dr-ci bot commented Sep 28, 2020 •

edited

codecov bot commented Sep 29, 2020 •

edited