Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch][QPL] Add instance_key into MOBILE_MODULE_STATS logging. #45517

Closed
wants to merge 1 commit into from

Conversation

xcheng16
Copy link
Contributor

@xcheng16 xcheng16 commented Sep 29, 2020

Stack from ghstack:

Add unique instance_key instead of the default one into MOBILE_MODULE_STATS logging to avoid multiple events overlaps.

Differential Revision: D23985178

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

Add unique instance_key instead of the default one into MOBILE_MODULE_STATS logging to avoid multiple events overlaps.

Differential Revision: [D23985178](https://our.internmc.facebook.com/intern/diff/D23985178/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D23985178/)!

[ghstack-poisoned]
xcheng16 added a commit that referenced this pull request Sep 29, 2020
Add unique instance_key instead of the default one into MOBILE_MODULE_STATS logging to avoid multiple events overlaps.

Differential Revision: [D23985178](https://our.internmc.facebook.com/intern/diff/D23985178/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D23985178/)!

ghstack-source-id: 113149453
Pull Request resolved: #45517
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 29, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 29, 2020

💊 CI failures summary and remediations

As of commit 48596e6 (more details on the Dr. CI page):



🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Sep 29 19:17:32 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']
Sep 29 19:17:32 AtenXlaType function missed override: Tensor smooth_l1_loss_backward(const Tensor& grad_output, const Tensor& self, const Tensor& target, int64_t reduction, double beta); // smooth_l1_loss_backward(Tensor,Tensor,Tensor,int64_t,double)->Tensor 
Sep 29 19:17:32 Traceback (most recent call last): 
Sep 29 19:17:32   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1163, in <module> 
Sep 29 19:17:32     generate(args) 
Sep 29 19:17:32   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1133, in generate 
Sep 29 19:17:32     assert check_overrides(overrides, overridden) 
Sep 29 19:17:32 AssertionError 
Sep 29 19:17:32 Building torch_xla version: 1.6 
Sep 29 19:17:32 XLA Commit ID: db18ba57137e9e082aab9337e148120ce5725b22 
Sep 29 19:17:32 PyTorch Commit ID: 053d6e4f86e1fd5a95c52717088c32ec015615b2 
Sep 29 19:17:32 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Sep 29 19:17:32 =================== sccache compilation log =================== 
Sep 29 19:17:32 + cleanup 
Sep 29 19:17:32 + retcode=1 
Sep 29 19:17:32 + set +x 
Sep 29 19:17:32 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Sep 29 19:17:32 Compile requests              6010 
Sep 29 19:17:32 Compile requests executed     3560 
Sep 29 19:17:32 Cache hits                    3544 
Sep 29 19:17:32 Cache misses                     0 
Sep 29 19:17:32 Cache timeouts                   0 

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_ios_11_2_1_x86_64_build (1/1)

Step: "Update Homebrew" (full log | diagnosis details | 🔁 rerun) ❄️

fatal: Could not read from remote repository.
Receiving objects:  98% (175/178) Receiving objects:  99% (177/178) Receiving objects: 100% (178/178) Receiving objects: 100% (178/178), 63.90 KiB | 10.65 MiB/s, done. 
Resolving deltas:  96% (89/92) Resolving deltas:  97% (90/92) Resolving deltas: 100% (92/92) Resolving deltas: 100% (92/92), completed with 85 local objects. 
From ssh://github.com/Homebrew/homebrew-cask-versions 
 + 15f6b44...90ed6b8 master     -> origin/master  (forced update) 
+ git reset --hard origin/master 
HEAD is now at 90ed6b8 Update microsoft-edge-beta from 86.0.622.19 to 86.0.622.28 (#9686) 
+ for path in '$(find /usr/local/Homebrew -type d -name .git)' 
+ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/.git/.. 
+ git fetch --depth=1 origin 
Connection to github.com closed by remote host.  
fatal: Could not read from remote repository. 
 
Please make sure you have the correct access rights 
and the repository exists. 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3f440d7.

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3f440d7.

@facebook-github-bot facebook-github-bot deleted the gh/xcheng16/34/head branch October 4, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants