Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-land: Add callgrind collection to Timer #44717 #45586

Closed
wants to merge 2 commits into from

Conversation

robieta
Copy link

@robieta robieta commented Sep 30, 2020

Test plan: The unit test has been softened to be less platform sensitive.

@robieta
Copy link
Author

robieta commented Sep 30, 2020

CC @ngimel @ezyang

@dr-ci
Copy link

dr-ci bot commented Sep 30, 2020

💊 CI failures summary and remediations

As of commit 6e9ad61 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robieta has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

robieta pushed a commit that referenced this pull request Sep 30, 2020
@ezyang
Copy link
Contributor

ezyang commented Oct 1, 2020

Huh, did we miss this last PR because slow tests aren't run by default? @seemethere do target specifiers work yet? O/W you can just push a synthetic PR to ci-all/ASDFAsdf branch to trigger all tests.

@facebook-github-bot
Copy link
Contributor

@robieta merged this pull request in 2b13d94.

malfet pushed a commit that referenced this pull request Oct 2, 2020
@robieta robieta deleted the gh/taylorrobie/reland_callgrind branch October 5, 2020 16:25
@xkszltl
Copy link
Contributor

xkszltl commented Oct 6, 2020

Want to bring up an issue with this PR:
The sourceware.org repo is extremely slow when accessing from China, almost unusable.
I have a local git mirror so it won't be too bad for me after the initial setup, but could be an terrible experience for others.

Should we ask for pre-built binary from distro, instead of having it as a submodule?

@ezyang
Copy link
Contributor

ezyang commented Oct 6, 2020

cc @malfet we should just go back to vendoring the headers directly

@malfet
Copy link
Contributor

malfet commented Oct 6, 2020

@ezyang we can totally do that, or simply create a mirror on github...

@xkszltl
Copy link
Contributor

xkszltl commented Oct 6, 2020

Actually I tried creating a mirror on GitHub just to reroute through its CDN, but somehow I end up with VCS detection error.
GitLab works.

@robieta
Copy link
Author

robieta commented Oct 6, 2020

I need to do a follow up PR to address a couple papercuts anyway, which I was going to do today. Do we have a preference between vendoring the headers vs. a mirror repo?

@ezyang
Copy link
Contributor

ezyang commented Oct 6, 2020

Header vendor seems much better to me

@malfet
Copy link
Contributor

malfet commented Oct 6, 2020

Following PR should embed the headers: #45914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants