[quant] PerChannelFloatQParams support for quint4x2 dtype #45594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24025595](https://our.internmc.facebook.com/intern/diff/D24025595) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Sep 30, 2020
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 97553da79ec9e1eb2a63516a5ce37a9747dd9264 Pull Request resolved: #45594
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24025595](https://our.internmc.facebook.com/intern/diff/D24025595) [ghstack-poisoned]
raghuramank100
approved these changes
Oct 1, 2020
No, it does require change. I've made changes to the |
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24025595](https://our.internmc.facebook.com/intern/diff/D24025595) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Oct 1, 2020
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a10aaeeebc5102d4e301d1d23e3a6ab257e9758d Pull Request resolved: #45594
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24025595](https://our.internmc.facebook.com/intern/diff/D24025595) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Oct 1, 2020
Summary: Adds support for Per-channel quantization using float qparams for 4-bit dtype We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the 4-bit data depending on the bit_width. Size of 4-bit quantized tensor is half that of 8-bit quantized tensor. Test Plan: python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2e8feabb1ffa50d6219b987ff78c796e5918903b Pull Request resolved: #45594
Codecov Report
@@ Coverage Diff @@
## gh/supriyar/190/base #45594 +/- ##
=====================================================
Coverage 68.50% 68.50%
=====================================================
Files 408 408
Lines 52487 52487
=====================================================
Hits 35954 35954
Misses 16533 16533 Continue to review full report at Codecov.
|
|
This pull request has been merged in 1a2d3b6. |
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds support for Per-channel quantization using float qparams for 4-bit dtype
We use the new dispatch mechanism and use existing quantize/dequantize kernels to pack the
4-bit data depending on the bit_width.
Size of 4-bit quantized tensor is half that of 8-bit quantized tensor.
Test Plan:
python test/test_quantization.py TestQuantizedTensor.test_quantize_per_channel_sub_byte
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24025595