Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix flatten operator #45632

Closed
wants to merge 3 commits into from
Closed

[ONNX] Fix flatten operator #45632

wants to merge 3 commits into from

Conversation

KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented Oct 1, 2020

Even when dim is None, there are cases when flatten can be exported.
Also enable test_densenet in scripting mode

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #45632 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #45632   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files         406      406           
  Lines       52285    52285           
=======================================
  Hits        35885    35885           
  Misses      16400    16400           
Impacted Files Coverage Δ
torch/onnx/symbolic_opset11.py 21.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3ad54...d4ba1f5. Read the comment docs.

Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@KsenijaS
Copy link
Contributor Author

@bzinodev Can this PR be merged?

@dr-ci
Copy link

dr-ci bot commented Oct 14, 2020

💊 CI failures summary and remediations

As of commit d4ba1f5 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 6ca03ae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants