Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asymmetric mkldnn convolutions for padding='same' convolutions #45668

Closed
wants to merge 19 commits into from

Conversation

peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Oct 1, 2020

Stack from ghstack:

peterbell10 added a commit that referenced this pull request Oct 1, 2020
ghstack-source-id: 7faae166738523864b0388a4664a3687ed606aaa
Pull Request resolved: #45668
peterbell10 added a commit that referenced this pull request Oct 1, 2020
ghstack-source-id: 2505f60a27881fa2be3f4b0ab080004d13176600
Pull Request resolved: #45668
peterbell10 added a commit that referenced this pull request Oct 1, 2020
ghstack-source-id: 52ddbf5aa6ee89c2772336d1c17310f8aca108ca
Pull Request resolved: #45668
@mrshenli mrshenli added module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: nn Related to torch.nn module: convolution Problems related to convolutions (THNN, THCUNN, CuDNN) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Oct 1, 2020
@mrshenli mrshenli requested a review from gchanan October 1, 2020 23:57
peterbell10 added a commit that referenced this pull request Oct 5, 2020
ghstack-source-id: c1436633629d2a20e6a2926d9d4c981ae2512bfd
Pull Request resolved: #45668
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Oct 5, 2020
ghstack-source-id: c1436633629d2a20e6a2926d9d4c981ae2512bfd
Pull Request resolved: pytorch#45668
peterbell10 added a commit that referenced this pull request Oct 5, 2020
ghstack-source-id: fd62f124a6a9f9ddfc48ba3b53b5ed4f0eaf8f85
Pull Request resolved: #45668
@facebook-github-bot
Copy link
Contributor

Hi @peterbell10!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

peterbell10 added a commit that referenced this pull request Feb 17, 2021
ghstack-source-id: 26d215c38a10f5ad2e3f1d17fc926630cf738c4a
Pull Request resolved: #45668
peterbell10 added a commit that referenced this pull request Feb 20, 2021
ghstack-source-id: 46dc0caf1098ae47d88fa5e74f46a8dc31fb0861
Pull Request resolved: #45668
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Mar 11, 2021
ghstack-source-id: df1720a5b9a46833c01df651bd5e86bbf9175983
Pull Request resolved: pytorch#45668
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Mar 15, 2021
ghstack-source-id: 8519f132f6a03a1854b2651c5f4a3aeb7d8c9285
Pull Request resolved: pytorch#45668
@mruberry
Copy link
Collaborator

@ngimel @jbschlosser are you two the correct reviewers for this?

@mruberry mruberry requested review from jbschlosser and removed request for gchanan, albanD, soulitzer and mruberry January 24, 2022 17:03
@mruberry
Copy link
Collaborator

Updating reviewers since it looks like this PR was lost in the shuffle

@jbschlosser
Copy link
Contributor

I'm good to review this, but do you mind rebasing please? @peterbell10 Might be a bit tricky due to the large convolution changes I landed recently.

@pytorchbot
Copy link
Collaborator

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions bot closed this May 12, 2022
@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/18/head branch June 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed module: convolution Problems related to convolutions (THNN, THCUNN, CuDNN) module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: nn Related to torch.nn open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants