Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reland][quant][graphmode][fx] Merge all quantization mode (#45292) #45672

Closed
wants to merge 2 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Oct 1, 2020

Stack from ghstack:

Summary:
This PR merges all quantization mode and will only expose the following top level functions:

prepare_fx
prepare_qat_fx
convert_fx

Test Plan: Imported from OSS

Reviewed By: vkuzo

Differential Revision: D24053439

Summary:
This PR merges all quantization mode and will only expose the following top level functions:
```
prepare_fx
prepare_qat_fx
convert_fx
```

Test Plan: Imported from OSS

Reviewed By: vkuzo

[ghstack-poisoned]
…#45292)"

Summary:
This PR merges all quantization mode and will only expose the following top level functions:
```
prepare_fx
prepare_qat_fx
convert_fx
```

Test Plan: Imported from OSS

Reviewed By: vkuzo

Differential Revision: [D24053439](https://our.internmc.facebook.com/intern/diff/D24053439)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Oct 1, 2020
Summary:
This PR merges all quantization mode and will only expose the following top level functions:
```
prepare_fx
prepare_qat_fx
convert_fx
```

Test Plan: Imported from OSS

Reviewed By: vkuzo

ghstack-source-id: 5208f72f119cea51fe4cf3fbf5358783415076d5
Pull Request resolved: #45672
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #45672 into gh/jerryzh168/447/base will increase coverage by 0.00%.
The diff coverage is 96.80%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           gh/jerryzh168/447/base   #45672   +/-   ##
=======================================================
  Coverage                   68.49%   68.50%           
=======================================================
  Files                         408      408           
  Lines                       52478    52433   -45     
=======================================================
- Hits                        35946    35919   -27     
+ Misses                      16532    16514   -18     
Impacted Files Coverage Δ
torch/quantization/fx/pattern_utils.py 87.23% <ø> (-1.86%) ⬇️
torch/testing/_internal/common_quantization.py 90.03% <87.50%> (+0.02%) ⬆️
torch/quantization/fx/utils.py 61.90% <93.75%> (+5.72%) ⬆️
torch/quantization/fx/quantization_patterns.py 96.53% <100.00%> (+4.31%) ⬆️
torch/quantization/fx/quantize.py 96.52% <100.00%> (+0.13%) ⬆️
torch/quantization/quantize_fx.py 91.42% <100.00%> (-3.74%) ⬇️
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bc3d9...932a793. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4f685ec.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/447/head branch October 5, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants