Minor gradcheck update to reduce computations #45757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Oct 2, 2020
ghstack-source-id: 4d1727be980f3e6edb73c51b8ac909760bbd0cb1 Pull Request resolved: #45757
albanD
approved these changes
Oct 5, 2020
| d[d_idx] = torch.real(dL_dz_conj) | ||
| # dL_dz_conj = 0.5 * [grad_out.conj() * ds_dx + grad_out * ds_dx.conj()] | ||
| # = 0.5 * [grad_out.conj() * ds_dx + (grad_out.conj() * ds_dx).conj()] | ||
| # = 0.5 * 2 * real(grad_out.conj() * ds_dx) |
There was a problem hiding this comment.
nit: if you want to go all the way, you can add an extra line with just the final formula that you implement below
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Oct 6, 2020
ghstack-source-id: 124780f16903c76158f77f0a1e45df60f196830c Pull Request resolved: #45757
|
@anjali411 merged this pull request in a3662fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D24137143