Rocm skip test cases #45782
Closed
Rocm skip test cases #45782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleCZH
requested review from
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
|
@ezyang @xw285cornell skipping these tests is necessary before we can migrate to the ROCm 3.8 CI image. Unfortunately, these tests were discovered as failing after our QA team validated the ROCm 3.8 release against a now older upstream commit. Rest assured we are working in earnest to triage these new failures, but we need more time and these failures are blocking our ability to migrate to the latest ROCm 3.8 CI image. |
ezyang
approved these changes
Oct 5, 2020
xw285cornell
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
@xw285cornell has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@xw285cornell merged this pull request in a9a9d0b. |
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Oct 14, 2020
Summary: Skip the following test cases for rocm (When PYTORCH_TEST_WITH_ROCM=1): - test_reference_numerics_tan_cuda_float64 (__main__.TestUnaryUfuncsCUDA) - test_addmv_cuda_float16 (__main__.TestTorchDeviceTypeCUDA) - test_logspace_cuda_float64 (__main__.TestTensorCreationCUDA) - test_gloo_backend_2gpu_module (__main__.DistributedDataParallelTest) jeffdaily pruthvistony Pull Request resolved: pytorch#45782 Reviewed By: VitalyFedyunin Differential Revision: D24115581 Pulled By: xw285cornell fbshipit-source-id: 4043a9fa19e242301b5007813c15b6b3873889c5
This was referenced Oct 14, 2020
malfet
pushed a commit
that referenced
this pull request
Oct 14, 2020
Summary: Skip the following test cases for rocm (When PYTORCH_TEST_WITH_ROCM=1): - test_reference_numerics_tan_cuda_float64 (__main__.TestUnaryUfuncsCUDA) - test_addmv_cuda_float16 (__main__.TestTorchDeviceTypeCUDA) - test_logspace_cuda_float64 (__main__.TestTensorCreationCUDA) - test_gloo_backend_2gpu_module (__main__.DistributedDataParallelTest) jeffdaily pruthvistony Pull Request resolved: #45782 Reviewed By: VitalyFedyunin Differential Revision: D24115581 Pulled By: xw285cornell fbshipit-source-id: 4043a9fa19e242301b5007813c15b6b3873889c5 Co-authored-by: KyleCZH <kylechen@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the following test cases for rocm (When PYTORCH_TEST_WITH_ROCM=1):
@jeffdaily
@pruthvistony