New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Enable NoneType inputs to export API #45792
[ONNX] Enable NoneType inputs to export API #45792
Conversation
…kare/named-optional-arguments
…kare/named-optional-arguments
…kare/named-optional-arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💊 CI failures summary and remediationsAs of commit 4874094 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
…kare/named-optional-arguments
Codecov Report
@@ Coverage Diff @@
## master #45792 +/- ##
==========================================
- Coverage 68.25% 68.25% -0.01%
==========================================
Files 410 410
Lines 53611 53611
==========================================
- Hits 36593 36592 -1
- Misses 17018 17019 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@bzinodev Any changes to be made on my side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@bzinodev Any changes to be made on my side? |
Enables the use of NoneType arguments to inputs tuple in the export API