Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Categorical docstring #45804

Closed
wants to merge 1 commit into from
Closed

Correct Categorical docstring #45804

wants to merge 1 commit into from

Conversation

ecotner
Copy link
Contributor

@ecotner ecotner commented Oct 3, 2020

Clarified that the Categorical distribution will actually accept input of any arbitrary tensor shape, not just 1D and 2D tensors.

Clarified that the `Categorical` distribution will actually accept input of any arbitrary tensor shape, not just 1D and 2D tensors.
@ecotner
Copy link
Contributor Author

ecotner commented Oct 3, 2020

First discovered this when trying to implement an ordered categorical distribution for pyro, FYI pyro-ppl/pyro#2651, this is NOT hacktoberfest spam haha

@ecotner
Copy link
Contributor Author

ecotner commented Oct 3, 2020

seems like one of the builds is failing... not sure why, the only thing I changed was the docstring! CircleCI says there is a failed test that says Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed, is that the problem?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@VitalyFedyunin merged this pull request in e4efc42.

@ecotner
Copy link
Contributor Author

ecotner commented Oct 27, 2020

@VitalyFedyunin I just realized I have enough commits this month to actually participate in hacktoberfest; would you consider marking this PR as hacktoberfest-accepted? Would be cool to get that t-shirt 😅

@ecotner
Copy link
Contributor Author

ecotner commented Oct 28, 2020

@mruberry I think the tag has to be literally hacktoberfest-accepted to count towards the event, not Merged. Sorry, I hope I'm not being too pushy 😞

@mruberry
Copy link
Collaborator

@mruberry I think the tag has to be literally hacktoberfest-accepted to count towards the event, not Merged. Sorry, I hope I'm not being too pushy 😞

Not at all, @ecotner, but we don't appear to have a "hacktoberfest-accepted" label, sorry. The addition of the Merged label was just a program adding labels for some stats we're generating.

@ecotner
Copy link
Contributor Author

ecotner commented Oct 30, 2020

Would it be too much to ask if you might be able to add a new label? It looks like there are already over 200 labels in this repo, some of which have never even been used before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants