Fix TypeError when torch.jit.load is passed a pathlib.Path #45825
Conversation
facebook-github-bot
added
the
oncall: jit
Codecov Report
@@ Coverage Diff @@
## master #45825 +/- ##
=======================================
Coverage 68.32% 68.32%
=======================================
Files 410 410
Lines 52978 52978
=======================================
+ Hits 36195 36196 +1
+ Misses 16783 16782 -1
Continue to review full report at Codecov.
|
|
Turns out |
| @@ -478,13 +478,13 @@ def code_with_constants(self): | |||
| r = self.forward.code_with_constants | |||
| return (r[0], ConstMap(r[1])) | |||
|
|
|||
| def save(self, f, _extra_files={}): | |||
| def save(self, f, **kwargs): | |||
There was a problem hiding this comment.
The lint error was because I was passing a mutable object (i.e. {}) as a default argument. Alternative solution would be to have None as the default with
if _extra_files is None:
_extra_files = {}inside the function. But before I made any changes the function was already using kwargs so I figured I'd just switch back to that.
|
Think it's ready now. Thanks! |
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@gmagogsfm merged this pull request in 9dc9a55. |
Fixes #45824