[dist_optim] serialize compilation when creating dist_optim #45871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix #45845 [ghstack-poisoned]
wanchaol
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
Attempt to fix #45845 [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/wanchaol/136/base #45871 +/- ##
========================================================
- Coverage 68.32% 68.32% -0.01%
========================================================
Files 410 410
Lines 52992 52997 +5
========================================================
+ Hits 36208 36210 +2
- Misses 16784 16787 +3
Continue to review full report at Codecov.
|
Attempt to fix #45845 Differential Revision: [D24125209](https://our.internmc.facebook.com/intern/diff/D24125209) [ghstack-poisoned]
pritamdamania87
approved these changes
Oct 7, 2020
|
Do we need this to be cherry-picked into v1.7? |
Yes I will submit the cherry-pick PR soon :) |
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR fixes #45845
The issue to the case is where request_callback spawn threads in the same process and when instantiating ScriptModule, it tries to compile concurrently. TorchScript compilation is not thread safe, so it results in the following failure:
This PR introduce a lock in ScriptLocalOptimizer to protect/serialize the compilation.
Differential Revision: D24125209