[ONNX] Improve error handling for adaptive_pool #45874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
…oof/fixAdaptiveAvg
Codecov Report
@@ Coverage Diff @@
## master #45874 +/- ##
==========================================
- Coverage 68.32% 68.31% -0.01%
==========================================
Files 410 410
Lines 52992 52997 +5
==========================================
- Hits 36208 36207 -1
- Misses 16784 16790 +6
Continue to review full report at Codecov.
|
bzinodev
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@bzinodev Can we merge this PR please? Thanks! |
neginraoof
added a commit
to neginraoof/pytorch
that referenced
this pull request
Oct 9, 2020
Summary: Duplicate of pytorch#43032 This update would also improve error handling for interpolate with 'area' mode. Pull Request resolved: pytorch#45874 Reviewed By: albanD Differential Revision: D24141266 Pulled By: bzinodev fbshipit-source-id: 7559f1d6af4f1ef3507c15a1aee76fe01fa433cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #43032
This update would also improve error handling for interpolate with 'area' mode.