[quant] Refactor qembeddingbag to remove duplicate code #45881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 6, 2020
supriyar
added a commit
that referenced
this pull request
Oct 6, 2020
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4fb4686b79c4978b628d7b00f1fffe61a4c15130 Pull Request resolved: #45881
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24127892](https://our.internmc.facebook.com/intern/diff/D24127892) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Oct 6, 2020
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 98dd91bbe0cfa26be089f601e773b3c135b704ce Pull Request resolved: #45881
Codecov Report
@@ Coverage Diff @@
## gh/supriyar/194/base #45881 +/- ##
=====================================================
Coverage 68.20% 68.20%
=====================================================
Files 410 410
Lines 53251 53251
=====================================================
Hits 36320 36320
Misses 16931 16931 Continue to review full report at Codecov.
|
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24127892](https://our.internmc.facebook.com/intern/diff/D24127892) [ghstack-poisoned]
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24127892](https://our.internmc.facebook.com/intern/diff/D24127892) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Oct 6, 2020
Summary: Test Plan: python test/test_quantization.py TestQuantizedEmbeddingBagOps Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f8d9a55d2660df9508456a6aa27fcfbe298ea704 Pull Request resolved: #45881
|
This pull request has been merged in 1b31ed3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
python test/test_quantization.py TestQuantizedEmbeddingBagOps
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24127892