Fix flakiness in caffe2/test:serialization - test_serialization_new_format_old_format_compat #45915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat_old_format_compat Summary: Use temp file instead Test Plan: buck test mode/opt-asan //caffe2/test:serialization -- 'test_serialization_new_format_old_format_compat \(test_serialization\.TestBothSerialization\)' --run-disabled --jobs 18 --stress-runs 10 --record-results Differential Revision: D24142278 fbshipit-source-id: 17931b44a883570ffded957f86dbcc4a4757bc7b
|
This pull request was exported from Phabricator. Differential Revision: D24142278 |
Codecov Report
@@ Coverage Diff @@
## master #45915 +/- ##
=======================================
Coverage 68.20% 68.20%
=======================================
Files 410 410
Lines 53243 53243
=======================================
+ Hits 36313 36314 +1
+ Misses 16930 16929 -1
Continue to review full report at Codecov.
|
|
This pull request has been merged in 275bb5e. |
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Oct 9, 2020
…ormat_old_format_compat (pytorch#45915) Summary: Pull Request resolved: pytorch#45915 Use temp file instead Test Plan: buck test mode/opt-asan //caffe2/test:serialization -- 'test_serialization_new_format_old_format_compat \(test_serialization\.TestBothSerialization\)' --run-disabled --jobs 18 --stress-runs 10 --record-results Reviewed By: malfet Differential Revision: D24142278 fbshipit-source-id: 9c88330fc5664d464daa9124e67644f497353f3b
This was referenced Oct 9, 2020
Merged
malfet
pushed a commit
that referenced
this pull request
Oct 10, 2020
…ormat_old_format_compat (#45915) (#46114) Summary: Pull Request resolved: #45915 Use temp file instead Test Plan: buck test mode/opt-asan //caffe2/test:serialization -- 'test_serialization_new_format_old_format_compat \(test_serialization\.TestBothSerialization\)' --run-disabled --jobs 18 --stress-runs 10 --record-results Reviewed By: malfet Differential Revision: D24142278 fbshipit-source-id: 9c88330fc5664d464daa9124e67644f497353f3b Co-authored-by: Rong Rong <rongr@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use temp file instead
Test Plan: buck test mode/opt-asan //caffe2/test:serialization -- 'test_serialization_new_format_old_format_compat (test_serialization.TestBothSerialization)' --run-disabled --jobs 18 --stress-runs 10 --record-results
Differential Revision: D24142278