Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize raising error message about unused parameters when rebuild_buckets fails #45933

Closed
wants to merge 4 commits into from

Commits on Oct 6, 2020

  1. Prioritize raising error message about unused parameters when rebuild…

    …_buckets fails
    
    Occasionally users run DDP with models with unused params, in this
    case we would like to surface an error message telling them to run with
    find_unused_params=True. However, a recent change to rebuild_buckets logic (#44798) made
    it so that we raise a size mismatch error when this happens, but the
    information about unused parameters is likely to be more useful and likely to
    be the most common case of failure. Prefer raising this error over the
    subsequent size mismatch errors.
    
    Differential Revision: [D24151256](https://our.internmc.facebook.com/intern/diff/D24151256/)
    
    [ghstack-poisoned]
    rohan-varma committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    cf02198 View commit details
    Browse the repository at this point in the history
  2. Update on "Prioritize raising error message about unused parameters w…

    …hen rebuild_buckets fails"
    
    Occasionally users run DDP with models with unused params, in this
    case we would like to surface an error message telling them to run with
    find_unused_params=True. However, a recent change to rebuild_buckets logic (#44798) made
    it so that we raise a size mismatch error when this happens, but the
    information about unused parameters is likely to be more useful and likely to
    be the most common case of failure. Prefer raising this error over the
    subsequent size mismatch errors.
    
    Differential Revision: [D24151256](https://our.internmc.facebook.com/intern/diff/D24151256/)
    
    [ghstack-poisoned]
    rohan-varma committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    f650e34 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Update on "Prioritize raising error message about unused parameters w…

    …hen rebuild_buckets fails"
    
    Occasionally users run DDP with models with unused params, in this
    case we would like to surface an error message telling them to run with
    find_unused_params=True. However, a recent change to rebuild_buckets logic (#44798) made
    it so that we raise a size mismatch error when this happens, but the
    information about unused parameters is likely to be more useful and likely to
    be the most common case of failure. Prefer raising this error over the
    subsequent size mismatch errors.
    
    Differential Revision: [D24151256](https://our.internmc.facebook.com/intern/diff/D24151256/)
    
    [ghstack-poisoned]
    rohan-varma committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    d1b71c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Update on "Prioritize raising error message about unused parameters w…

    …hen rebuild_buckets fails"
    
    Occasionally users run DDP with models with unused params, in this
    case we would like to surface an error message telling them to run with
    find_unused_params=True. However, a recent change to rebuild_buckets logic (#44798) made
    it so that we raise a size mismatch error when this happens, but the
    information about unused parameters is likely to be more useful and likely to
    be the most common case of failure. Prefer raising this error over the
    subsequent size mismatch errors.
    
    Differential Revision: [D24151256](https://our.internmc.facebook.com/intern/diff/D24151256/)
    
    [ghstack-poisoned]
    rohan-varma committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ec9826a View commit details
    Browse the repository at this point in the history