Enable CUDA Fuser for ROCm #45965
Enable CUDA Fuser for ROCm #45965
Conversation
facebook-github-bot
added
the
oncall: jit
Part of this patch is based on work of Rohith Nallamaddi, thank you. Errors are my own, of course.
|
@jeffdaily @rohithkrn @walterddr @malfet @sunway513 (in part based on ROCm#712 ) |
|
Oh, and @csarofeen @jjsjann123 , I hope I didn't screw up your code too much. |
|
The caffe2 ROCm CI is timing out due to an unrelated change to master, scheduled to be reverted. Also, ROCm CI moved to the 3.8 image this morning, in case we want to verify this PR against the newer image, too. |
|
I think ROCm 3.8 should be relatively safe given that I'm running it with success there. But I can also push an empty commit to rerun the CI. |
|
No need to push empty commit. We can use pytorchbot. |
|
Let's wait until the caffe2 PR is reverted, though. |
|
@pytorchbot retest this please |
|
CI looks good. |
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
If I understand the messages correctly, this is about the Caffe2 breakage. If it helps, I can rebase, just shout. |
|
@walterddr merged this pull request in d3d8da7. |
Summary: This enables the cuda fuser on ROCm and enables tests for them. Part of this patch is based on work of Rohith Nallamaddi, thank you. Errors are my own, of course. Pull Request resolved: pytorch/pytorch#45965 Reviewed By: seemethere Differential Revision: D24170457 Pulled By: walterddr fbshipit-source-id: 3dd25b3501a41d2f00acba3ce8642ce51c49c9a6
Summary: This enables the cuda fuser on ROCm and enables tests for them. Part of this patch is based on work of Rohith Nallamaddi, thank you. Errors are my own, of course. Pull Request resolved: pytorch/pytorch#45965 Reviewed By: seemethere Differential Revision: D24170457 Pulled By: walterddr fbshipit-source-id: 3dd25b3501a41d2f00acba3ce8642ce51c49c9a6
This enables the cuda fuser on ROCm and enables tests for them.
Part of this patch is based on work of Rohith Nallamaddi, thank you.
Errors are my own, of course.