Support %-based string formatting

[ansley]

Stack from ghstack:

• Support %-based string formatting #45976 Support %-based string formatting

Differential Revision: D24374215

[gmagogsfm]

Reviewed part of it, please address current comments and we can iterate.

[dr-ci]

💊 CI failures summary and remediations

As of commit 59b6fd0 (more details on the Dr. CI page):

---

✅ None of the CI failures appear to be your fault 💚

---

• 5/5 broken upstream at merge base ac146c4 on Oct 19 from 1:55pm to 5:29pm PDT (5 commits; 7b2e8be - 8f12c0e)

---

🚧 5 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

• pytorch_linux_bionic_py3_8_gcc9_coverage_test on Oct 19 from 1:55pm to 5:29pm PDT (5 commits; 7b2e8be - 8f12c0e)
  • 🔁 rerun
• pytorch_linux_xenial_py3_6_gcc5_4_test on Oct 19 from 1:55pm to 5:29pm PDT (5 commits; 7b2e8be - 8f12c0e)
  • 🔁 rerun
• pytorch_linux_xenial_py3_clang5_asan_test2 on Oct 19 from 1:55pm to 5:29pm PDT (5 commits; 7b2e8be - 8f12c0e)
  • 🔁 rerun
• pytorch_linux_bionic_py3_6_clang9_test on Oct 19 from 1:55pm to 5:29pm PDT (5 commits; 7b2e8be - 8f12c0e)
  • 🔁 rerun
• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 on Oct 19 from 1:55pm to 5:29pm PDT (5 commits; 7b2e8be - 8f12c0e)
  • 🔁 rerun

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 71 times.

[gmagogsfm]

Add a TORCH_CHECK to ensure that there is only 1 input when its type is tuple.

[ansley]

Under what circumstances would there not be only one input? I believe that the modulo operator is always parsed into a Tree with a left child and a right child. This means that a test case like the one below would fail before hitting IREmitter at all.

# This test does not raise the correct error! Instead, it raises "cannot call a value of type 'Tuple[str, int]'"
def test_string_interpolation_with_double_tuple(self):
    with self.assertRaisesRegex(RuntimeError, "Argument to format string must be a single str or Tuple"):
        @torch.jit.script
        def fn(arg1: str, arg2: int, arg3: float, arg4: str) -> str:
            return "%s %d %f %s in template" % (arg1, arg2) (arg3, arg4)
        fn("foo", 1, 1.0, "bar")

[codecov]

Codecov Report

Merging #45976 into gh/ansleyadelaide/9/base will increase coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           gh/ansleyadelaide/9/base   #45976   +/-   ##
=========================================================
  Coverage                     68.38%   68.38%           
=========================================================
  Files                           411      411           
  Lines                         53950    53950           
=========================================================
+ Hits                          36893    36895    +2     
+ Misses                        17057    17055    -2     

Impacted Files	Coverage Δ
torch/utils/benchmark/utils/common.py	99.31% <0.00%> (+0.68%)	⬆️
torch/testing/_internal/expecttest.py	78.57% <0.00%> (+1.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7cd97...4f4dd64. Read the comment docs.

[facebook-github-bot]

@ansley merged this pull request in fdc5261.