Workaround for cublas bug for 45724 #46001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimel
reviewed
Oct 8, 2020
aten/src/THC/THCBlas.cu
Outdated
| return cublasGemmStridedBatchedEx(handle, transa, transb, m, n, k, alpha, A, Atype, lda, strideA, B, Btype, ldb, strideB, beta, C, Ctype, ldc, strideC, batchCount, computeType, algo); | ||
| } | ||
| cublasStatus_t result; | ||
| for(int64_t i = 0; i < batchCount; i += 65535) { |
There was a problem hiding this comment.
hm, can you make it something rounder than 65535 here? You have a good chance of having horrible alignment
There was a problem hiding this comment.
changed to 63 * 1024
ngimel
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #46001 +/- ##
=======================================
Coverage 68.25% 68.25%
=======================================
Files 410 410
Lines 53246 53246
=======================================
Hits 36343 36343
Misses 16903 16903 Continue to review full report at Codecov.
|
zasdfgbnm
added a commit
that referenced
this pull request
Oct 8, 2020
malfet
pushed a commit
that referenced
this pull request
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45724