Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.fft: Add helper functions section to docs #46032

Closed
wants to merge 2 commits into from

Conversation

peterbell10
Copy link
Collaborator

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry
Copy link
Collaborator

mruberry commented Oct 8, 2020

Doc build failures are real:

Oct 08 13:11:12 docstring of torch.fft.fftshift:44: WARNING: Unexpected indentation.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #46032 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #46032   +/-   ##
=======================================
  Coverage   68.26%   68.26%           
=======================================
  Files         410      410           
  Lines       53287    53287           
=======================================
+ Hits        36378    36379    +1     
+ Misses      16909    16908    -1     
Impacted Files Coverage Δ
torch/fft/__init__.py 100.00% <ø> (ø)
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bff9e...c0499a2. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in c86ee08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants