[Distributed] Adding getNumKeys support to the HashStore #46048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for the getNumKeys API for the HashStore Differential Revision: [D24067658](https://our.internmc.facebook.com/intern/diff/D24067658/) [ghstack-poisoned]
osalpekar
requested review from
mingzhe09088,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: distributed
Codecov Report
@@ Coverage Diff @@
## gh/osalpekar/93/base #46048 +/- ##
=====================================================
Coverage 68.28% 68.28%
=====================================================
Files 410 410
Lines 53306 53306
=====================================================
Hits 36398 36398
Misses 16908 16908 Continue to review full report at Codecov.
|
jiayisuse
approved these changes
Oct 13, 2020
|
This pull request has been merged in 74f13a8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds support for the getNumKeys API for the HashStore
Differential Revision: D24067658