Fix error in Binomial to retain lazy logit initialization #46055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46055 +/- ##
==========================================
- Coverage 68.26% 68.26% -0.01%
==========================================
Files 410 410
Lines 53328 53323 -5
==========================================
- Hits 36403 36399 -4
+ Misses 16925 16924 -1
Continue to review full report at Codecov.
|
fritzo
approved these changes
Oct 9, 2020
|
@pytorchbot merge this please |
pytorchbot
added
the
merge-this-please
There was a problem hiding this comment.
@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@neerajprad merged this pull request in 9202c44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal tests were sporadically failing for #45648. The cause of this is a bug in
Binomial.__init__that references the lazylogitsattribute and sets it when not needed. This cleans up theis_scalarlogic too which isn't needed given thatbroadcast_allwill convertNumberto atensor.The reason for the flakiness is the mutation of the params dict by the first test, which is fixed by doing a shallow copy. It will be better to convert this into a pytest parameterized test once #45648 is merged.
cc. @fritzo, @ezyang