Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.7 patch] Remove object-based collective APIs from public docs #46109

Merged
merged 3 commits into from
Oct 10, 2020

Conversation

rohan-varma
Copy link
Member

Summary:

Note: This PR has been merged into master at 362d9a9 after the 1.7 branch cut
(see original PR: #46075). This PR is to merge it into the 1.7 branch.

---- Original Commit Description Follows ---

#46075 Remove object-based collective APIs from public docs
Removes these from public docs for now as we are still
iterating/formalizing these APIs. Will add them back once they are part of a
PyTorch release.

Differential Revision: D24211510

Summary:
Pull Request resolved: #46075

Removes these from public docs for now as we are still
iterating/formalizing these APIs. Will add them back once they are part of a
PyTorch release.
ghstack-source-id: 113928700

Test Plan: CI

Reviewed By: mrshenli

Differential Revision: D24211510

fbshipit-source-id: 3e36ff6990cf8e6ef72b6e524322ae06f9097aa2
@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 9, 2020
@dr-ci
Copy link

dr-ci bot commented Oct 9, 2020

💊 CI failures summary and remediations

As of commit 4035abe (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #46109 into release/1.7 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.7   #46109      +/-   ##
===============================================
- Coverage        68.46%   68.46%   -0.01%     
===============================================
  Files              406      406              
  Lines            52267    52267              
===============================================
- Hits             35785    35784       -1     
- Misses           16482    16483       +1     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93ae1e...4035abe. Read the comment docs.

@malfet malfet merged commit 379d624 into release/1.7 Oct 10, 2020
@facebook-github-bot facebook-github-bot deleted the cherry_pick_dist_docs_fix branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants