Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few more comments on dispatch key computation methods #46128

Closed
wants to merge 2 commits into from

Conversation

bhosmer
Copy link
Contributor

@bhosmer bhosmer commented Oct 10, 2020

Stack from ghstack:

Differential Revision: D24233868

bhosmer added a commit that referenced this pull request Oct 10, 2020
ghstack-source-id: e31d96a3e80cfa0b9dca64bc0e158ec2d16f4f08
Pull Request resolved: #46128
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #46128 into gh/bhosmer/52/base will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           gh/bhosmer/52/base   #46128   +/-   ##
===================================================
  Coverage               68.20%   68.20%           
===================================================
  Files                     410      410           
  Lines                   53453    53453           
===================================================
+ Hits                    36457    36458    +1     
+ Misses                  16996    16995    -1     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 78.57% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689499f...3c77498. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@bhosmer merged this pull request in 9f74301.

@facebook-github-bot facebook-github-bot deleted the gh/bhosmer/52/head branch October 13, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants