Avoid computing AutogradKey if not needed. #46252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: CI Differential Revision: D24272744 fbshipit-source-id: 1b2255770def16d1373dc59b911e8e66d9ec6ffc
|
This pull request was exported from Phabricator. Differential Revision: D24272744 |
bhosmer
approved these changes
Oct 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #46252 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 410 410
Lines 53611 53611
=======================================
+ Hits 36608 36609 +1
+ Misses 17003 17002 -1
Continue to review full report at Codecov.
|
|
This pull request has been merged in a37f274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: CI
Differential Revision: D24272744