Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Update peephole pass for prim::ListUnpack #46264

Closed
wants to merge 13 commits into from
Closed

[ONNX] Update peephole pass for prim::ListUnpack #46264

wants to merge 13 commits into from

Conversation

KsenijaS
Copy link
Contributor

Update pass that handles prim::ListUnpack in peephole file, so that it also covers the case when input to the node is of ListType.

Fixes #45816

@dr-ci
Copy link

dr-ci bot commented Oct 13, 2020 •
edited

💊 CI failures summary and remediations

As of commit 753b08f (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

codecov.io: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 43 times.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 13, 2020
@heitorschueroff heitorschueroff added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 14, 2020
BowenBao
BowenBao reviewed Oct 19, 2020
View reviewed changes
torch/csrc/jit/passes/onnx/peephole.cpp Outdated Show resolved Hide resolved
torch/csrc/jit/passes/onnx/peephole.cpp Outdated Show resolved Hide resolved
BowenBao
BowenBao approved these changes Oct 23, 2020
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks

torch/csrc/jit/passes/onnx/peephole.cpp Outdated Show resolved Hide resolved
test/onnx/test_pytorch_onnx_onnxruntime.py Show resolved Hide resolved
test/onnx/test_pytorch_onnx_onnxruntime.py Show resolved Hide resolved
@KsenijaS
Copy link
Contributor Author

@bzinodev can you please review? Thanks!

facebook-github-bot
facebook-github-bot reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@BowenBao
Copy link
Collaborator

Test failure related, please have a look @KsenijaS

@KsenijaS KsenijaS mentioned this pull request Oct 28, 2020
Closed
@facebook-github-bot
Copy link
Contributor

Hi @KsenijaS!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@KsenijaS KsenijaS mentioned this pull request Oct 31, 2020
Closed
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #46264 into master will decrease coverage by 0.00%.
The diff coverage is 28.00%.

@@            Coverage Diff             @@
##           master   #46264      +/-   ##
==========================================
- Coverage   60.81%   60.81%   -0.01%     
==========================================
  Files        2749     2749              
  Lines      254098   254123      +25     
==========================================
+ Hits       154536   154541       +5     
- Misses      99562    99582      +20

facebook-github-bot
facebook-github-bot reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bzinodev merged this pull request in 7a59987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@BowenBao BowenBao BowenBao approved these changes

@bzinodev bzinodev bzinodev approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@houseroad houseroad Awaiting requested review from houseroad

Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ONNX export : unrecognised node type
6 participants
@KsenijaS @BowenBao @facebook-github-bot @bzinodev @heitorschueroff @pytorchbot