Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding BAND/BOR/BXOR reduce ops to unsupported list for complex numbers. added tests #46270

Closed
wants to merge 1 commit into from

Conversation

bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Oct 13, 2020

Stack from ghstack:

Differential Revision: D24284702

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Oct 13, 2020
bdhirsh added a commit that referenced this pull request Oct 13, 2020
…rs. added tests

ghstack-source-id: 498bc5f29b95c759cab4ef683447022b87625189
Pull Request resolved: #46270
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #46270 into gh/bdhirsh/24/base will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           gh/bdhirsh/24/base   #46270      +/-   ##
======================================================
- Coverage               68.25%   68.25%   -0.01%     
======================================================
  Files                     410      410              
  Lines                   53611    53613       +2     
======================================================
  Hits                    36593    36593              
- Misses                  17018    17020       +2     
Impacted Files Coverage Δ
torch/distributed/distributed_c10d.py 27.29% <0.00%> (ø)
.../testing/_internal/distributed/distributed_test.py 29.69% <20.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc846db...80626ab. Read the comment docs.

@dr-ci
Copy link

dr-ci bot commented Oct 13, 2020

💊 CI failures summary and remediations

As of commit 80626ab (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@anjali411 anjali411 self-requested a review October 13, 2020 23:30
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Oct 14, 2020
@facebook-github-bot
Copy link
Contributor

@bdhirsh merged this pull request in 1f791c0.

@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/24/head branch October 18, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: complex Related to complex number support in PyTorch oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants