Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues in torch.tensor_split documentation #46328

Closed

Conversation

kurtamohler
Copy link
Collaborator

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 14, 2020

💊 CI failures summary and remediations

As of commit 09b31362e9 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR---

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_clang5_asan_test2 Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

torch/_torch_docs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kurtamohler! Just have one question for you. Ping me when you'd like this merged.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #46328 into master will increase coverage by 0.02%.
The diff coverage is 80.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #46328      +/-   ##
==========================================
+ Coverage   68.31%   68.33%   +0.02%     
==========================================
  Files         410      410              
  Lines       53582    53783     +201     
==========================================
+ Hits        36602    36752     +150     
- Misses      16980    17031      +51     
Impacted Files Coverage Δ
torch/_torch_docs.py 100.00% <ø> (ø)
torch/distributed/distributed_c10d.py 27.29% <0.00%> (ø)
torch/nn/quantized/modules/__init__.py 97.22% <ø> (ø)
torch/testing/_internal/expecttest.py 78.57% <ø> (+1.02%) ⬆️
...orch/testing/_internal/distributed/rpc/rpc_test.py 26.29% <12.50%> (-0.18%) ⬇️
torch/distributed/rpc/api.py 30.04% <16.66%> (ø)
.../testing/_internal/distributed/rpc/jit/rpc_test.py 28.97% <18.18%> (-0.17%) ⬇️
.../testing/_internal/distributed/distributed_test.py 29.69% <20.00%> (-0.03%) ⬇️
torch/futures/__init__.py 84.61% <50.00%> (-2.89%) ⬇️
torch/jit/annotations.py 91.78% <50.00%> (-0.39%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635aebd...70247c6. Read the comment docs.

@kurtamohler
Copy link
Collaborator Author

@mruberry, I think this is good now.

@dr-ci
Copy link

dr-ci bot commented Oct 14, 2020

💊 CI failures summary and remediations

As of commit 70247c6 (more details on the Dr. CI page):



🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_libtorch_linux_xenial_cuda11_0_cudnn8_py3_gcc7_test (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun)

E: Unable to locate package expect-dev
E: Unable to locate package expect-dev 
+ sudo apt-get -y install moreutils expect-dev 
Reading package lists... 100%  Reading package lists... Done  
Building dependency tree... 50%  Building dependency tree         
Reading state information... 0%  Reading state information... Done  
Package moreutils is not available, but is referred to by another package. 
This may mean that the package is missing, has been obsoleted, or 
is only available from another source 
 
E: Package 'moreutils' has no installation candidate 
E: Unable to locate package expect-dev 

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:


🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in bd44933.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants